Skip to content

RDKEAPPRT-879,324 - Remove CEC Plugin Activation/Deactivation from CEC Control Setting #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SudarsananComcast wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

RDKEAPPRT-879,324 - Remove CEC Plugin Activation/Deactivation from CEC Control Setting #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d222f2
removed activate for CEC api
Jul 10, 2026
8f591a0
added condition for CEC toggle button
Jul 13, 2026
7d6e823
added perform otp in initState
Jul 13, 2026
99137f8
changed toggle spelling
SudarsananComcast Jul 13, 2026
68fb27a
added logs
Jul 14, 2026
9ff3638
Merge branch 'rdkeApprt-879' of https://github.com/rdkcentral/rdke-re…
Jul 14, 2026
86fb68a
sync with develop
SudarsananComcast Jul 15, 2026
8fedff3
version changed
SudarsananComcast Jul 15, 2026
bfb6357
version changed
SudarsananComcast Jul 15, 2026
38c4be4
removed activated for CEC Api
SudarsananComcast Jul 17, 2026
0af4a10
used storage to store the CEC Status
SudarsananComcast Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accelerator-home-ui/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"log": true,
"enableAppSuspended": true,
"showVersion": false,
"version": "6.0.27"
"version": "6.0.28"
}
}
4 changes: 2 additions & 2 deletions accelerator-home-ui/src/api/CECApi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ export default class CECApi {
})
}

setEnabled() {
setEnabled(enabled = true) {
return new Promise((resolve) => {
thunder.call('org.rdk.HdmiCecSource', 'setEnabled', { enabled: true })
thunder.call('org.rdk.HdmiCecSource', 'setEnabled', { enabled })
.then(result => {
resolve(result)
})
Expand Down
70 changes: 52 additions & 18 deletions accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
**/
import { Lightning, Utils, Language } from '@lightningjs/sdk'
import { Lightning, Utils, Language, Storage } from '@lightningjs/sdk'
import SettingsMainItem from '../../items/SettingsMainItem'
import { COLORS } from '../../colors/Colors'
import { CONFIG } from '../../Config/Config'
Expand Down Expand Up @@ -171,21 +171,47 @@
}

}

// function which handles changes on and off toggle image.
updateCECButtonState(isEnabled) {
this.tag('CECControl.Button').src = Utils.asset(
isEnabled
? 'images/settings/ToggleOnOrange.png'
: 'images/settings/ToggleOffWhite.png'
)
}

_init() {
this.cecApi = new CECApi()
this.cecApi.activate()
.then(() => {
this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png')
// get current state from store preference for CEC status
const storedPreference = Storage.get('CECEnabledPreference')
if (storedPreference !== undefined && storedPreference !== null) {
const isEnabled = storedPreference === true || storedPreference === 'true'
// if the state is true,then update the CEC toggle.
this.updateCECButtonState(isEnabled)
if (isEnabled) {
this.performOTPAction()
}
this._setState('CECControl')
return
}
this.cecApi.getEnabled()
.then(res => {
Comment thread
SudarsananComcast marked this conversation as resolved.
const isEnabled = !!(res && res.enabled)
this.updateCECButtonState(isEnabled)
// update the store preference for CEC state.
Storage.set('CECEnabledPreference', isEnabled)
if (isEnabled) {
this.performOTPAction()
}
})
this._setState('CECControl')
}
_focus() {
this._setState('CECControl')
}
performOTPAction() {
this.cecApi.setEnabled().then(res => {
this.cecApi.setEnabled(true).then(res => {
if (res.success) {
this.cecApi.performOTP().then(otpRes => {
if (otpRes.success) {
Expand All @@ -199,19 +225,27 @@
toggleCEC() {
this.cecApi.getEnabled()
.then(res => {
this.LOG("toggleCEC getEnabled result: " + JSON.stringify(res))
if (res.enabled) {
this.cecApi.deactivate()
.then(() => {
this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOffWhite.png')
})
}
else {
this.cecApi.activate()
.then(() => {
this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png')
})
}
this.LOG('toggleCEC getEnabled result: ' + JSON.stringify(res))
const newEnabledState = !(res && res.enabled)
// if newEnabledState is true,then first activate CEC and then setEnabled to true,
// else just setEnabled to false
const togglePromise = newEnabledState
? this.cecApi.activate().then(() => this.cecApi.setEnabled(true))
: this.cecApi.setEnabled(false)

togglePromise
.then(() => {
// update the stored preference and button state after toggle
Storage.set('CECEnabledPreference', newEnabledState)
this.updateCECButtonState(newEnabledState)

if (newEnabledState) {
this.performOTPAction()
}
})
.catch(err => {
this.ERR('CEC toggle failed: ' + JSON.stringify(err))
})
})
}

Expand Down
70 changes: 52 additions & 18 deletions accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
**/
import { Lightning, Utils, Language, Router } from '@lightningjs/sdk'
import { Lightning, Utils, Language, Router, Storage } from '@lightningjs/sdk'
import SettingsMainItem from '../../items/SettingsMainItem'
import { COLORS } from '../../colors/Colors'
import { CONFIG } from '../../Config/Config'
Expand Down Expand Up @@ -179,13 +179,39 @@ export default class AdvanceSettingsScreen extends Lightning.Component {
}

}
// function which handles changes on and off toggle image.
updateCECButtonState(isEnabled) {
this.tag('CECControl.Button').src = Utils.asset(
isEnabled
? 'images/settings/ToggleOnOrange.png'
: 'images/settings/ToggleOffWhite.png'
)
}

_init() {
this.cecApi = new CECApi()
this.cecApi.activate()
.then(() => {
this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png')
const storedPreference = Storage.get('CECEnabledPreference')
// get current state from store preference for CEC status
if (storedPreference !== undefined && storedPreference !== null) {
const isEnabled = storedPreference === true || storedPreference === 'true'
// if the state is true,then update the CEC toggle.
this.updateCECButtonState(isEnabled)
if (isEnabled) {
this.performOTPAction()
}
this._setState('TTSOptions')
return
}

this.cecApi.getEnabled()
.then(res => {
Comment thread
SudarsananComcast marked this conversation as resolved.
const isEnabled = !!(res && res.enabled)
this.updateCECButtonState(isEnabled)
// update the store preference for CEC state.
Storage.set('CECEnabledPreference', isEnabled)
if (isEnabled) {
this.performOTPAction()
}
})
this._setState('TTSOptions')
}
Expand All @@ -200,7 +226,7 @@ export default class AdvanceSettingsScreen extends Lightning.Component {
}

performOTPAction() {
this.cecApi.setEnabled().then(res => {
this.cecApi.setEnabled(true).then(res => {
if (res.success) {
this.cecApi.performOTP().then(otpRes => {
if (otpRes.success) {
Expand All @@ -214,19 +240,27 @@ export default class AdvanceSettingsScreen extends Lightning.Component {
toggleCEC() {
this.cecApi.getEnabled()
.then(res => {
this.LOG("cec getenabled result:" + JSON.stringify(res))
if (res.enabled) {
this.cecApi.deactivate()
.then(() => {
this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOffWhite.png')
})
}
else {
this.cecApi.activate()
.then(() => {
this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png')
})
}
this.LOG('toggleCEC getEnabled result: ' + JSON.stringify(res))
const newEnabledState = !(res && res.enabled)
// if newEnabledState is true,then first activate CEC and then setEnabled to true,
// else just setEnabled to false
const togglePromise = newEnabledState
? this.cecApi.activate().then(() => this.cecApi.setEnabled(true))
: this.cecApi.setEnabled(false)

togglePromise
.then(() => {
// update the stored preference and button state after toggle
Storage.set('CECEnabledPreference', newEnabledState)
this.updateCECButtonState(newEnabledState)

if (newEnabledState) {
this.performOTPAction()
}
})
.catch(err => {
this.ERR('CEC toggle failed: ' + JSON.stringify(err))
})
})
}
static _states() {
Expand Down
4 changes: 2 additions & 2 deletions bolt/package-configs/com.rdkcentral.refui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "com.rdkcentral.refui",
"version": "6.0.27",
"versionName": "6.0.27",
"version": "6.0.28",
"versionName": "6.0.28",
"name": "RDK Ref UI Home Screen",
"packageType": "application",
"entryPoint": "--lightning --dev file:///usr/share/refui/index.html",
Expand Down