RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI - #148
Open
vanemage wants to merge 1 commit into
Open
RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI#148vanemage wants to merge 1 commit into
vanemage wants to merge 1 commit into
Conversation
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the XB6 WebUI “onewifi” wireless configuration action handler by adding stricter validation and mapping for ssid_number, intended to address security vulnerability findings around untrusted input affecting TR-181 paths and radio selection.
Changes:
- Adds SSID instance bounds (
$MIN_SSID_INSTANCE,$MAX_SSID_INSTANCES) and validatesssid_numberlength/format/range with 400 responses on invalid input. - Introduces
ResolveRadioFromSsid()to constrain which SSID instances are allowed to map to radios. - Refactors the non-
band_steeringpath to derive$rvia the mapping helper and adds a small apply helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+161
to
+163
| $get_channel_automatic = getStr("Device.WiFi.Radio."+$r+".AutoChannelEnable"); | ||
| $get_wireless_mode = getStr("Device.WiFi.Radio."+$r+".OperatingStandards"); | ||
| $get_channel_bandwidth = getStr("Device.WiFi.Radio."+$r+".OperatingChannelBandwidth"); |
Comment on lines
+153
to
+154
| $i = String($arConfig['ssid_number']); | ||
| $r = ResolveRadioFromSsid($i); |
Comment on lines
+108
to
109
|
|
||
| if($i == "17") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.