Skip to content

RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanemage wants to merge 1 commit into
base: develop
Choose a base branch
from
+58 −7
Open

RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 58 additions & 7 deletions source/Styles/xb6/jst/actionHandler/ajaxSet_wireless_network_configuration_onewifi.jst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ $Radio_Enable = ($Radio_1_Enable == 'true' || $Radio_2_Enable == 'true') ? true
$Radio_1_Support_Modes = getStr("Device.WiFi.Radio.1.SupportedStandards");
$Radio_2_Support_Modes = getStr("Device.WiFi.Radio.2.SupportedStandards");
$partnerId = getStr("Device.DeviceInfo.X_RDKCENTRAL-COM_Syndication.PartnerId");
$MIN_SSID_INSTANCE = 1; // Minimum valid SSID instance number per TR-181 RDK-B DM
$MAX_SSID_INSTANCES = 24; // Maximum: 8 SSIDs x 3 radios (2.4GHz + 5GHz + 6GHz tri-band)
$wps_ssids = [];
if ($Radio_1_Enable == 'true') $wps_ssids.push(1);
if ($Radio_2_Enable == 'true') $wps_ssids.push(2);
Expand All @@ -57,6 +59,20 @@ function validFilterParam($ft){
}
return true;
}

function ResolveRadioFromSsid($ssid){
global $MIN_SSID_INSTANCE, $MAX_SSID_INSTANCES;
$ssid_tmp = String($ssid);
if (preg_match('/^\d+$/', $ssid_tmp) != 1) return "";
$ssid_num = intval($ssid_tmp);
if ($ssid_num < $MIN_SSID_INSTANCE || $ssid_num > $MAX_SSID_INSTANCES) return "";
if ($ssid_num == 1) return 1;
if ($ssid_num == 2) return 2;
if ($ssid_num == 17) return 3;
return "";
}


if ($_POST['configInfo']) {
$jsConfig = $_POST['configInfo'];
} else if ($_GET['configInfo']){
Expand All @@ -66,7 +82,30 @@ if ($_POST['configInfo']) {
//$jsConfig = '{"ssid_number":"1", "ft":[["1","2"],["c","d"]], "target":"save_filter"}';
$arConfig = json_decode($jsConfig, true);
//print_r($arConfig);
$i = $arConfig['ssid_number'];
$i = (array_key_exists('ssid_number', $arConfig)) ? String($arConfig['ssid_number']) : "";
$ssid_log = substr(String($i), 0, 32);
if ($i != "" && strlen($i) > 3) {
LogStr(" : security_event:invalid_ssid_number_length:" + String(strlen($i)) + " value_prefix:" + $ssid_log);
http_response_code(400);
echo( '{"error":"invalid_ssid_number"}');
exit(0);
}

if ($i != "" && (preg_match('/^\d+$/', $i) != 1)) {
LogStr(" : security_event:invalid_ssid_number_format value_prefix:" + $ssid_log);
http_response_code(400);
echo( '{"error":"invalid_ssid_number"}');
exit(0);
}

// Strict numeric boundary check: reject SSID numbers outside valid DM range
if ($i != "" && (intval($i) < $MIN_SSID_INSTANCE || intval($i) > $MAX_SSID_INSTANCES)) {
LogStr(" : security_event:invalid_ssid_number_range value:" + $ssid_log);
http_response_code(400);
echo( '{"error":"invalid_ssid_number"}');
exit(0);
}

if($i == "17")
Comment on lines +108 to 109
{
$Radio_3_Enable = getStr("Device.WiFi.Radio.3.Enable");
Expand Down Expand Up @@ -111,12 +150,24 @@ if (array_key_exists('band_steering', $arConfig))
}
else
{
$i = $arConfig['ssid_number'];
if($i == 17)
$r=3; //17th is private ssid for 6 GHz(radio 3)
else
$r = $i;
$channel = getStr("Device.WiFi.Radio."+$r+".AutoChannelEnable");
$i = String($arConfig['ssid_number']);
$r = ResolveRadioFromSsid($i);
Comment on lines +153 to +154
if ($r == "") {
LogStr(" : security_event:invalid_ssid_mapping ssid:" + substr(String($i), 0, 32));
http_response_code(400);
echo( '{"error":"invalid_ssid_mapping"}');
exit(0);
}
$get_channel_automatic = getStr("Device.WiFi.Radio."+$r+".AutoChannelEnable");
$get_wireless_mode = getStr("Device.WiFi.Radio."+$r+".OperatingStandards");
$get_channel_bandwidth = getStr("Device.WiFi.Radio."+$r+".OperatingChannelBandwidth");
Comment on lines +161 to +163
function MiniApplySSID($ssid) {
$apply_rf = ResolveRadioFromSsid($ssid);
if ($apply_rf == "")
return;
setStr("Device.WiFi.Radio."+$apply_rf+".X_CISCO_COM_ApplySetting", "true", true);
}

if ("save_config" == $arConfig['target'])
{
//save_basic & save_advance is only for mso
Expand Down
Loading