[depre] Remove deprecated AssertPropertyExistsRector - #742
Merged
Conversation
TomasVotruba
force-pushed
the
deprecate-interface-assert-property-exists
branch
from
July 31, 2026 16:52
d0dad6f to
31c4d6e
Compare
The rule was already deprecated and threw on refactor(), as the assertClassHasAttribute() method it produced was removed in PHPUnit 10. It had no tests and was not part of any set.
TomasVotruba
force-pushed
the
deprecate-interface-assert-property-exists
branch
from
July 31, 2026 16:54
31c4d6e to
597f0a4
Compare
TomasVotruba
changed the title
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertPropertyExistsRectorwas already deprecated - it carried a@deprecatedtag andrefactor()threw:The method it produced,
assertClassHasAttribute(), was removed in PHPUnit 10, so there is nothing left for the rule to do. It had no tests, no set membership and no references anywhere in the repo.Same treatment as
AddCoversClassAttributeRector,AssertCountWithZeroToAssertEmptyRectorandAssertCompareToSpecificMethodRectorbefore it - the file goes.PHPStan, ECS and class-leak pass on the removal.