fix: hide admin lifecycle buttons from non-admin users#3217
Closed
rrbanda wants to merge 1 commit into
Closed
Conversation
Non-admin users now see role-appropriate controls in AgentLifecycleDetail: - Draft stage: "Submit for Review" button (the only mutation they can do) - Review stage: read-only "Awaiting admin approval" chip - Other stages: read-only stage label chip - "Rebuild" button hidden for non-admins (requires admin/Kagenti access) Admins retain full access to all lifecycle transition buttons. The isAdmin prop is now passed through from ChatView and the admin KagentiAgentsPanel. Part of Epic redhat-developer#3208
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
- Coverage 53.41% 53.41% -0.01%
==========================================
Files 2373 2373
Lines 84895 84907 +12
Branches 23568 23580 +12
==========================================
+ Hits 45349 45351 +2
+ Misses 39200 38009 -1191
- Partials 346 1547 +1201
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing: superseded by Phase 2 (#3223) which consolidates role-aware buttons with rejection UI and auto-redirect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentLifecycleDetail:isAdminprop added toAgentLifecycleDetailPropsand threaded through fromChatViewandKagentiAgentsPanelPart of Epic #3208
Test plan