Skip to content

fix: hide admin lifecycle buttons from non-admin users #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rrbanda wants to merge 1 commit into from
Closed

fix: hide admin lifecycle buttons from non-admin users #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 119 additions & 65 deletions ...augment/plugins/augment/src/components/AdminPanels/KagentiPanels/AgentLifecycleDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import {
getLifecycleStep,
} from './lifecycleTransitions';
import PlayArrowIcon from '@mui/icons-material/PlayArrow';
import InfoOutlinedIcon from '@mui/icons-material/InfoOutlined';
import { useApi, configApiRef, fetchApiRef } from '@backstage/core-plugin-api';
import type { KagentiAgentSummary } from '@red-hat-developer-hub/backstage-plugin-augment-common';
import { normalizeLifecycleStage } from '@red-hat-developer-hub/backstage-plugin-augment-common';
Expand Down Expand Up @@ -71,6 +72,7 @@ export interface AgentLifecycleDetailProps {
agent: KagentiAgentSummary;
onBack: () => void;
onChatWithAgent?: (agentId: string) => void;
isAdmin?: boolean;
}

/**
Expand All @@ -81,6 +83,7 @@ export function AgentLifecycleDetail({
agent,
onBack,
onChatWithAgent,
isAdmin = false,
}: AgentLifecycleDetailProps) {
const theme = useTheme();
const isDark = theme.palette.mode === 'dark';
Expand Down Expand Up @@ -280,71 +283,122 @@ export function AgentLifecycleDetail({
flexShrink: 0,
}}
>
{lifecycleStage !== 'retired' && (
<Tooltip title={nextTransition.label}>
<Button
size="small"
variant={nextTransition.variant}
color={nextTransition.color}
startIcon={
publishLoading ? (
<CircularProgress size={14} />
) : (
nextTransition.icon
)
}
disabled={publishLoading}
onClick={handleLifecycleAction}
sx={{
textTransform: 'none',
fontWeight: 600,
fontSize: '0.8rem',
borderRadius: borderRadius.sm,
}}
>
{nextTransition.label}
</Button>
</Tooltip>
)}
{lifecycleStage === 'retired' && (
<Tooltip title="Reactivate this agent to draft status">
<Button
size="small"
variant="outlined"
color="inherit"
startIcon={
publishLoading ? (
<CircularProgress size={14} />
) : (
<PublishIcon />
)
}
disabled={publishLoading}
onClick={handleLifecycleAction}
sx={{
textTransform: 'none',
fontWeight: 600,
fontSize: '0.8rem',
borderRadius: borderRadius.sm,
}}
>
Reactivate
</Button>
</Tooltip>
)}
{hasBuild && (
<Tooltip title="Trigger a new container image build">
<Button
size="small"
variant="outlined"
startIcon={<PlayArrowIcon />}
disabled={buildTriggering}
onClick={() => void handleTriggerBuild()}
sx={{ textTransform: 'none', borderRadius: borderRadius.sm }}
>
{buildTriggering ? 'Building...' : 'Rebuild'}
</Button>
</Tooltip>
{isAdmin ? (
<>
{lifecycleStage !== 'retired' && (
<Tooltip title={nextTransition.label}>
<Button
size="small"
variant={nextTransition.variant}
color={nextTransition.color}
startIcon={
publishLoading ? (
<CircularProgress size={14} />
) : (
nextTransition.icon
)
}
disabled={publishLoading}
onClick={handleLifecycleAction}
sx={{
textTransform: 'none',
fontWeight: 600,
fontSize: '0.8rem',
borderRadius: borderRadius.sm,
}}
>
{nextTransition.label}
</Button>
</Tooltip>
)}
{lifecycleStage === 'retired' && (
<Tooltip title="Reactivate this agent to draft status">
<Button
size="small"
variant="outlined"
color="inherit"
startIcon={
publishLoading ? (
<CircularProgress size={14} />
) : (
<PublishIcon />
)
}
disabled={publishLoading}
onClick={handleLifecycleAction}
sx={{
textTransform: 'none',
fontWeight: 600,
fontSize: '0.8rem',
borderRadius: borderRadius.sm,
}}
>
Reactivate
</Button>
</Tooltip>
)}
{hasBuild && (
<Tooltip title="Trigger a new container image build">
<Button
size="small"
variant="outlined"
startIcon={<PlayArrowIcon />}
disabled={buildTriggering}
onClick={() => void handleTriggerBuild()}
sx={{
textTransform: 'none',
borderRadius: borderRadius.sm,
}}
>
{buildTriggering ? 'Building...' : 'Rebuild'}
</Button>
</Tooltip>
)}
</>
) : (
<>
{lifecycleStage === 'draft' && (
<Tooltip title="Submit for Review">
<Button
size="small"
variant="contained"
color="primary"
startIcon={
publishLoading ? (
<CircularProgress size={14} />
) : (
<PublishIcon />
)
}
disabled={publishLoading}
onClick={handleLifecycleAction}
sx={{
textTransform: 'none',
fontWeight: 600,
fontSize: '0.8rem',
borderRadius: borderRadius.sm,
}}
>
Submit for Review
</Button>
</Tooltip>
)}
{lifecycleStage !== 'draft' && (
<Chip
icon={<InfoOutlinedIcon sx={{ fontSize: 14 }} />}
label={
lifecycleStage === 'review'
? 'Awaiting admin approval'
: lifecycleStage.charAt(0).toUpperCase() +
lifecycleStage.slice(1)
}
size="small"
variant="outlined"
color={lifecycleStage === 'review' ? 'info' : 'default'}
sx={{ fontWeight: 500, fontSize: '0.78rem' }}
/>
)}
</>
)}
{onChatWithAgent && (
<Button
Expand Down
1 change: 1 addition & 0 deletions ...s/augment/plugins/augment/src/components/AdminPanels/KagentiPanels/KagentiAgentsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ export function KagentiAgentsPanel({
return (
<AgentLifecycleDetail
agent={selectedAgent}
isAdmin
onBack={() => {
setSelectedAgent(null);
loadAgents();
Expand Down
1 change: 1 addition & 0 deletions workspaces/augment/plugins/augment/src/components/AugmentPage/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ export function ChatView({
agent={detailAgent}
onBack={handleCloseDetail}
onChatWithAgent={handleChatWithAgent}
isAdmin={isAdmin}
/>
</Box>
)}
Expand Down
Loading