Fix ObjectIsFrozenException when using string.IsNullOrEmpty/IsNullOrWhiteSpace in Where lambda bindings#2014
Draft
Fix ObjectIsFrozenException when using string.IsNullOrEmpty/IsNullOrWhiteSpace in Where lambda bindings#2014
Conversation
…ranslation Agent-Logs-Url: https://github.com/riganti/dotvvm/sessions/13a597db-6d37-4df2-99f1-73f83128f1c8 Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug in binding translation for expressions
Fix ObjectIsFrozenException when using string.IsNullOrEmpty/IsNullOrWhiteSpace in Where lambda bindings
Apr 2, 2026
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| var binding = bindingHelper.ValueBinding<IEnumerable<TestViewModel2>>( | ||
| expression, | ||
| new[] { typeof(TestViewModel) }); | ||
| var simplePath = binding.GetProperty(typeof(SimplePathExpressionBindingProperty), ErrorHandlingMode.ThrowException); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bindings like
{value: _root.SessionsToShow.Where(s => string.IsNullOrEmpty(s.CategoryId)).ToList()}threwObjectIsFrozenExceptionwhen computingSimplePathExpressionBindingProperty.Root cause
string.IsNullOrEmptytranslates to!(a?.length > 0)— aJsBinaryExpression(comparison, precedence 12) inside aJsUnaryExpression(!, precedence 16). Because 12 < 16,JsParensFixingVisitortries to wrap the binary expression in aJsParenthesizedExpressionviaReplaceWith. However,FormatParametrizedScriptwas called directly on the frozenKnockoutJsExpressionBindingPropertyexpression (frozen after compilation), soReplaceWithhitThrowIfFrozen().FormatJavascriptalready handles this correctly by always cloning before transformation;FormatSimplePathdid not.Fix
JsAstHelpers.FormatParametrizedScript: clone the node if frozen before callingFixParenthesis, which mutates the tree in-place.JavascriptCompilationTests: added regression tests verifyingSimplePathExpressionBindingPropertyis computed without exception forWhere(v => string.IsNullOrEmpty(...))andWhere(v => string.IsNullOrWhiteSpace(...)).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)1p7vsblobprodcus324.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)4m6vsblobprodcus384.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)7devsblobprodcus323.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/00DA3BA51762B14D47D4C9F6E8A232CB/missingpackages_workingdir --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)cflvsblobprodcus383.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)jd4vsblobprodcus366.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)k0ivsblobprodcus356.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)k4kvsblobprodcus344.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)m6xvsblobprodcus342.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)pdfvsblobprodcus380.vsblob.vsassets.io/usr/bin/dotnet dotnet build src/Tests/DotVVM.Framework.Tests.csproj -c Release(dns block)pe3vsblobprodcus354.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)yttvsblobprodcus357.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-bfcb369f5dc91785/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: