update point and url table display component templates#1661
Merged
lyubov-voloshko merged 2 commits intomainfrom Mar 12, 2026
Merged
update point and url table display component templates#1661lyubov-voloshko merged 2 commits intomainfrom
lyubov-voloshko merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates table display field Angular templates to use the newer built-in control flow syntax (@if/@else) for rendering URL and Point field values in the UI components layer.
Changes:
- Refactor URL display template from
*ngIfto@if/@else. - Refactor Point display template from
*ngIfto@if.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/app/components/ui-components/table-display-fields/url/url.component.html | Switch conditional rendering to @if/@else for valid vs invalid URLs. |
| frontend/src/app/components/ui-components/table-display-fields/point/point.component.html | Switch conditional rendering to @if when a formatted point value exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </a> | ||
| <span *ngIf="!isValidUrl">{{value() || '—'}}</span> | ||
| @if (isValidUrl) { | ||
| <a [href]="hrefValue" target="_blank" |
There was a problem hiding this comment.
Links opened with target="_blank" should include rel="noopener noreferrer" to prevent reverse-tabnabbing and avoid exposing window.opener to the linked page. Add the rel attribute on this anchor.
Suggested change
| <a [href]="hrefValue" target="_blank" | |
| <a [href]="hrefValue" target="_blank" rel="noopener noreferrer" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.