Skip to content

update point and url table display component templates #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 2 commits into from
Mar 12, 2026
Merged

update point and url table display component templates #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f3aa7d
update point and url table display component templates
lyubov-voloshko Mar 12, 2026
5bb5673
Merge branch 'main' into signals-migration
lyubov-voloshko Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions frontend/src/app/components/ui-components/table-display-fields/point/point.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<div class="field-wrapper" *ngIf="formattedPoint">
<span class="value-wrapper" [matTooltip]="formattedPoint">{{ formattedPoint }}</span>
<button mat-icon-button
class="copy-button"
[cdkCopyToClipboard]="formattedPoint"
matTooltip="Copy to clipboard"
(cdkCopyToClipboardCopied)="onCopyToClipboard.emit('Field value was copied to clipboard.')"
(click)="$event.stopPropagation()">
<mat-icon>content_copy</mat-icon>
</button>
</div>
@if (formattedPoint) {
<div class="field-wrapper">
<span class="value-wrapper" [matTooltip]="formattedPoint">{{ formattedPoint }}</span>
<button mat-icon-button
class="copy-button"
[cdkCopyToClipboard]="formattedPoint"
matTooltip="Copy to clipboard"
(cdkCopyToClipboardCopied)="onCopyToClipboard.emit('Field value was copied to clipboard.')"
(click)="$event.stopPropagation()">
<mat-icon>content_copy</mat-icon>
</button>
</div>
}
18 changes: 10 additions & 8 deletions frontend/src/app/components/ui-components/table-display-fields/url/url.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<div class="field-display">
<span class="field-value">
<a *ngIf="isValidUrl"
[href]="hrefValue" target="_blank"
class="url-link"
(click)="$event.stopPropagation()">
<mat-icon class="url-link__icon" fontSet="material-symbols-outlined">link</mat-icon>
{{value() || '—'}}
</a>
<span *ngIf="!isValidUrl">{{value() || '—'}}</span>
@if (isValidUrl) {
<a [href]="hrefValue" target="_blank"
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links opened with target="_blank" should include rel="noopener noreferrer" to prevent reverse-tabnabbing and avoid exposing window.opener to the linked page. Add the rel attribute on this anchor.

Suggested change
<a [href]="hrefValue" target="_blank"
<a [href]="hrefValue" target="_blank" rel="noopener noreferrer"

Copilot uses AI. Check for mistakes.
class="url-link"
(click)="$event.stopPropagation()">
<mat-icon class="url-link__icon" fontSet="material-symbols-outlined">link</mat-icon>
{{value() || '—'}}
</a>
} @else {
<span>{{value() || '—'}}</span>
}
</span>
<button type="button" mat-icon-button
class="field-copy-button"
Expand Down
Loading