[RQT-JTC] limits from jtc controlled joints#1146
Merged
bmagyar merged 4 commits intoJun 5, 2024
Merged
Conversation
changed default value from `odom` -> `base_link`
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
github-actions
Bot
requested review from
VX792,
arne48,
bmagyar,
christophfroehlich,
destogl,
erickisos and
livanov93
christophfroehlich
approved these changes
May 23, 2024
christophfroehlich
left a comment
christophfroehlich
left a comment
Member
There was a problem hiding this comment.
Thanks for extracting this change.
I tested it with genuine continuous and revolute joints as well as with a revolute joint missing lower/upper limits -> LGTM
bmagyar
approved these changes
Jun 5, 2024
Member
|
@Mergifyio backport iron humble |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit 0ae3e42)
mergify Bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit 0ae3e42)
bmagyar
pushed a commit
that referenced
this pull request
Aug 28, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 29, 2024
greencookie-afk
pushed a commit
to greencookie-afk/ros2_controllers
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The further explanation of this issue is here #1131