Fix bug for displaying all controllers (backport #1259)#1271
Merged
Conversation
(cherry picked from commit 3be3fe9) # Conflicts: # rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
Contributor
Author
|
Cherry-pick of 3be3fe9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Member
|
Let's merge backport #1274 first |
Contributor
Author
|
This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich? |
Member
|
@Mergifyio rebase |
Contributor
Author
☑️ Nothing to doDetails
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1271 +/- ##
==========================================
- Coverage 65.23% 65.22% -0.02%
==========================================
Files 103 103
Lines 11435 11436 +1
Branches 7252 7253 +1
==========================================
- Hits 7460 7459 -1
- Misses 1476 1477 +1
- Partials 2499 2500 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Aug 28, 2024
saikishor
approved these changes
Aug 28, 2024
bmagyar
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When using the rqt_joint_trajectory_controller, not all the controllers are shown on the controller button. This is because the list of limits was not accumulated, and only the last one was considered. This PR fixes this, showing all the valid controllers.
I hope it helps
Francisco
This is an automatic backport of pull request #1259 done by [Mergify](https://mergify.com).