Skip to content

fix(joint-trajectory-controller): use active tolerances in update step#2101

Open
domire8 wants to merge 2 commits into
ros-controls:masterfrom
domire8:fix/tolerances
Open

fix(joint-trajectory-controller): use active tolerances in update step#2101
domire8 wants to merge 2 commits into
ros-controls:masterfrom
domire8:fix/tolerances

Conversation

@domire8

@domire8 domire8 commented Jan 8, 2026

Copy link
Copy Markdown

This PR fixes issue #2100

@codecov

codecov Bot commented Jan 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (c703235) to head (b0dfa37).
⚠️ Report is 52 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2101   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         151      151           
  Lines       14607    14607           
  Branches     1266     1266           
=======================================
  Hits        12386    12386           
  Misses       1763     1763           
  Partials      458      458           
Flag Coverage Δ
unittests 84.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 83.88% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Feb 23, 2026
@domire8

domire8 commented Feb 23, 2026

Copy link
Copy Markdown
Author

I believe this would still be valid @christophfroehlich ?

@github-actions github-actions Bot removed the stale label Feb 24, 2026

@MarqRazz MarqRazz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when a goal includes tolerances and then a follow up one does not? Will it fall back to the default_tolerances_ when they are not specified?

@domire8

domire8 commented Feb 25, 2026

Copy link
Copy Markdown
Author

What happens when a goal includes tolerances and then a follow up one does not? Will it fall back to the default_tolerances_ when they are not specified?

The way I understand this part, yes.

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Apr 13, 2026
@domire8

domire8 commented Apr 13, 2026

Copy link
Copy Markdown
Author

This PR is not stale

@github-actions github-actions Bot removed the stale label Apr 14, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

3 participants