SFix safety concerns with halt logic across controllers#2326
Open
lali-perelman wants to merge 1 commit into
Open
SFix safety concerns with halt logic across controllers#2326lali-perelman wants to merge 1 commit into
lali-perelman wants to merge 1 commit into
Conversation
github-actions
Bot
requested review from
bijoua29,
destogl,
fmauch,
moriarty and
saikishor
Contributor
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the safety concerns in the halt logic as described in issue #2325. I updated the mecanum, omni, and steering controllers to use blocking set_value(0.0, -1) and OR logic to ensure all wheels attempt to stop even if one fails.