Skip to content

Use new chainable controller exports API#2350

Open
saikishor wants to merge 7 commits into
ros-controls:masterfrom
pal-robotics-forks:use/new_chainable_controller_exports/api
Open

Use new chainable controller exports API#2350
saikishor wants to merge 7 commits into
ros-controls:masterfrom
pal-robotics-forks:use/new_chainable_controller_exports/api

Conversation

@saikishor

Copy link
Copy Markdown
Member

I've migrated the controllers to the new chainable controller export API, the older API needs to be deprecated soon.

Related to ros-controls/ros2_control#2988

@saikishor saikishor force-pushed the use/new_chainable_controller_exports/api branch from 1895647 to 89371ef Compare May 18, 2026 20:15
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.51887% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (01f6f40) to head (0d2b712).

Files with missing lines Patch % Lines
...dmittance_controller/src/admittance_controller.cpp 83.72% 0 Missing and 7 partials ⚠️
pid_controller/src/pid_controller.cpp 88.33% 6 Missing and 1 partial ⚠️
...iff_drive_controller/src/diff_drive_controller.cpp 92.00% 1 Missing and 1 partial ⚠️
..._drive_controller/src/mecanum_drive_controller.cpp 97.36% 0 Missing and 1 partial ⚠️
...ive_controller/src/omni_wheel_drive_controller.cpp 96.87% 0 Missing and 1 partial ⚠️
...llers_library/src/steering_controllers_library.cpp 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2350      +/-   ##
==========================================
+ Coverage   85.41%   85.47%   +0.06%     
==========================================
  Files         145      145              
  Lines       15375    15469      +94     
  Branches     1314     1316       +2     
==========================================
+ Hits        13132    13222      +90     
- Misses       1761     1763       +2     
- Partials      482      484       +2     
Flag Coverage Δ
unittests 85.47% <95.51%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <100.00%> (ø)
...roller/test/test_ackermann_steering_controller.hpp 88.39% <100.00%> (+0.10%) ⬆️
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 85.71% <100.00%> (ø)
chained_filter_controller/src/chained_filter.cpp 79.36% <100.00%> (-0.33%) ⬇️
...ned_filter_controller/test/test_chained_filter.cpp 98.33% <100.00%> (ø)
...r_controller/test/test_multiple_chained_filter.cpp 98.11% <100.00%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 95.10% <100.00%> (+0.03%) ⬆️
...roadcaster/src/force_torque_sensor_broadcaster.cpp 90.15% <100.00%> (+0.46%) ⬆️
..._sensor_broadcaster/src/imu_sensor_broadcaster.cpp 83.78% <100.00%> (-2.74%) ⬇️
... and 16 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant