fix: update dead documentation links#2398
Open
Ishan1923 wants to merge 1 commit into
Open
Conversation
Member
|
please rebase the relevant commit on top of the master branch |
github-actions
Bot
requested review from
Juliaj,
Maverobot,
destogl,
moriarty and
saikishor
Ishan1923
force-pushed
the
fix/motion-primitives-link
branch
from
1931bee to
732f237
Compare
christophfroehlich
requested changes
Jun 9, 2026
christophfroehlich
left a comment
christophfroehlich
left a comment
Member
There was a problem hiding this comment.
there is unrelated (but valid) cleanup in other files. please split this in two PRs
Contributor
Author
|
apologies; I have reset the branch to the latest upstream master and force-pushed the single commit for both link fixes. |
saikishor
reviewed
Jun 9, 2026
| :---------: | :----: | :----------: | :-----------: | :---------------: | ||
| **Rolling** | [`master`](https://github.com/ros-controls/ros2_controllers/tree/master) | [](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-binary-build.yml?branch=master) <br> [](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-semi-binary-build.yml?branch=master) <br> [](https://build.ros2.org/job/Rdev__ros2_controllers__ubuntu_resolute_amd64/) | [control.ros.org](https://control.ros.org/master/doc/ros2_controllers/doc/controllers_index.html) | [](https://build.ros2.org/job/Rbin_uR64__ros2_controllers__ubuntu_resolute_amd64__binary/) | ||
| **Lyrical** | [`master`](https://github.com/ros-controls/ros2_controllers/tree/master) | see above <br> [](https://build.ros2.org/job/Ldev__ros2_controllers__ubuntu_resolute_amd64/) | [control.ros.org](https://control.ros.org/master/doc/ros2_controllers/doc/controllers_index.html) | [](https://build.ros2.org/job/Lbin_uR64__ros2_controllers__ubuntu_resolute_amd64__binary/) | ||
| **Rolling** | [`master`](https://github.com/ros-controls/ros2_controllers/tree/master) | [](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-binary-build.yml?branch=master) <br> [](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-semi-binary-build.yml?branch=master) <br> [](https://build.ros2.org/job/Rdev__ros2_controllers__ubuntu_resolute_amd64/) | [control.ros.org](https://control.ros.org/rolling/doc/ros2_controllers/doc/controllers_index.html) | [](https://build.ros2.org/job/Rbin_uR64__ros2_controllers__ubuntu_resolute_amd64__binary/) |
Contributor
Author
There was a problem hiding this comment.
this was an unintended modification to the README table. I accidentally overwrote the Lyrical CI row while applying the URL fixes.
I will revert this specific file and ensure only the broken control.ros.org/master URLs are updated.
Ishan1923
changed the title
Ishan1923
force-pushed
the
fix/motion-primitives-link
branch
from
732f237 to
9656705
Compare
Member
There was a problem hiding this comment.
changes here are still not related?
saikishor
reviewed
Jun 9, 2026
saikishor
left a comment
saikishor
left a comment
Member
There was a problem hiding this comment.
There are still unrelated changes. Please fix
Ishan1923
force-pushed
the
fix/motion-primitives-link
branch
from
9656705 to
9a8b442
Compare
Contributor
Author
|
this PR now strictly addresses the motion_primitives broken link. |
Ishan1923
force-pushed
the
fix/motion-primitives-link
branch
from
9a8b442 to
ee83539
Compare
Contributor
Author
|
The unrelated changes have been removed. This PR now only contains the fix for the motion_primitives broken link. The master to rolling URL updates have been moved to #2409. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dead documentation links causing CI 404 failures:
ExecuteMotionPrimitiveSequence.actionlink by pointing tomaster(themotion_primitivesbranch was deleted post-merge ros-controls/control_msgs#228).control.ros.org/masterroutes torolling.Related Issue
Resolves #2397