Skip to content

Simplify reduce_wheel_speed_until_steering_reached logic (backport #2396)#2426

Merged
christophfroehlich merged 1 commit into
humblefrom
mergify/bp/humble/pr-2396
Jun 18, 2026
Merged

Simplify reduce_wheel_speed_until_steering_reached logic (backport #2396)#2426
christophfroehlich merged 1 commit into
humblefrom
mergify/bp/humble/pr-2396

Conversation

@mergify

@mergify mergify Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description

While checking #2392 I was confused by the code. I used the chance to simplify the logic a bit.

Is this user-facing behavior change?

Minimal, the scale is continuous now as cos(max_phi_delta) / cos(min_phi_delta) is not exactly 0.01.

Did you use Generative AI?

no

Additional Information


This is an automatic backport of pull request #2396 done by [Mergify](https://mergify.com).

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.44%. Comparing base (96b399d) to head (b33c432).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2426      +/-   ##
==========================================
- Coverage   69.45%   69.44%   -0.01%     
==========================================
  Files         128      128              
  Lines       14580    14579       -1     
  Branches     9174     9170       -4     
==========================================
- Hits        10126    10125       -1     
  Misses       1185     1185              
  Partials     3269     3269              
Flag Coverage Δ
unittests 69.44% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ring_controllers_library/src/steering_odometry.cpp 81.92% <100.00%> (-0.11%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 67bd15d into humble Jun 18, 2026
15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-2396 branch June 18, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant