Closed
Conversation
…nd on the AMENT_PREFIX_PATH env var. Able to colcon build the entire workspace.
- Change the CI to use a WIP version of cargo-ament-build - Remove extra line from subscription.rs which caused test failures
…rehsed instead of completely refreshed.
…brought one of my comments back.
The unused imports are because we do not necessarily use all dependencies in all modules. For example, action_msgs is often used only in the action module, but we have no way of knowing that ahead of time. I don't think it's valuable to document local modules that mock file structure.
Collaborator
Author
|
Not 100% sure what the issue is with my approach for regular ubuntu builds, but I was able to verify that window builds work now and locally I can still build on ubuntu. I will release a new version of ros-env to crates.io that fixes the build for #556 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.