Only check top-level symbol when deciding to skip sort predicate rules #4134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix checked `isEvaluated` on the term in a sort predicate before applying rules. This is correct but leads to too many fall-backs which slow down symbolic execution when sort predicates are used in rewrite side conditions. The only case that matters is when an _unevaluated function_ is at the _head_ of the term in the sort predicate. This is now matched directly.
jberthold
force-pushed
the
HOTFIX-only-check-term-top-level-for-sort-predicates
branch
from
400b523 to
b14ad6b
Compare
jberthold
commented
Dec 18, 2025
Comment on lines
-882
to
+889
| ModifiersRep (_ :: FromModifiersT mods => Proxy mods) -> do | ||
| pure $ | ||
| Left | ||
| ( \ctxt -> ctxt $ logWarn "Refusing to apply sort predicate rule to an unevaluated term" | ||
| , IndeterminateMatch | ||
| ) | ||
| pure $ | ||
| Left | ||
| ( \ctxt -> | ||
| ctxt $ | ||
| withTermContext term $ | ||
| withContext CtxWarn $ | ||
| logMessage ("Refusing to apply sort predicate rule to an unevaluated term" :: Text) | ||
| , IndeterminateMatch | ||
| ) |
Member
Author
There was a problem hiding this comment.
Also modified the logging to include the term with function head, for easier debugging
tothtamas28
approved these changes
Dec 18, 2025
Member
Author
|
Seems to be working now, and no negative impact on KEVM proofs.
|
jberthold
deleted the
HOTFIX-only-check-term-top-level-for-sort-predicates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix #4133 checked
isEvaluatedon the term in a sort predicate before applying rules. This is correct but leads to too many fall-backs which slow down symbolic execution when sort predicates are used in rewrite side conditions. The only case that matters is when an unevaluated function is at the head of the term in the sort predicate. This is now matched directly.