Skip to content

Only check top-level symbol when deciding to skip sort predicate rules #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jberthold merged 4 commits into from
Dec 18, 2025
Merged

Only check top-level symbol when deciding to skip sort predicate rules #4134

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b14ad6b
Only check top-level symbol when deciding to skip sort predicate rules
jberthold Dec 18, 2025
0099366
update test expectation for simplification log (fewer fall-backs)
jberthold Dec 18, 2025
8afe8e3
fix function head match (was missing kseq node), revert log test expe…
jberthold Dec 18, 2025
3d3bf0d
Adjust log test expectation to new logging
jberthold Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions booster/library/Booster/Pattern/ApplyEquations.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,18 +873,20 @@ applyEquation ::
EquationT
io
(Either ((EquationT io () -> EquationT io ()) -> EquationT io (), ApplyEquationFailure) Term)
applyEquation (FunctionApplication _sym [] [Term term _]) rule
applyEquation (FunctionApplication _sym [] [term]) rule
| isSortPredicate rule
, not term.isEvaluated =
, FunctionApplication _ _ _ <- term =
-- sort predicates only match on a sort injection, unevaluated
-- function applications may create false negatives
getPrettyModifiers >>= \case
ModifiersRep (_ :: FromModifiersT mods => Proxy mods) -> do
pure $
Left
( \ctxt -> ctxt $ logWarn "Refusing to apply sort predicate rule to an unevaluated term"
, IndeterminateMatch
)
pure $
Left
( \ctxt ->
ctxt $
withTermContext term $
withContext CtxWarn $
logMessage ("Refusing to apply sort predicate rule to an unevaluated term" :: Text)
, IndeterminateMatch
)
Comment on lines -882 to +889
Copy link
Member Author

@jberthold jberthold Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also modified the logging to include the term with function head, for easier debugging

applyEquation term rule =
runExceptT $
getPrettyModifiers >>= \case
Expand Down
Loading
Loading