add neon load/store assembly test#154094
Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
add neon load/store assembly test try-job: test-various
Contributor
Contributor
|
LGTM, and the test pass too! @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 21, 2026
… r=sayantn add neon load/store assembly test I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics. r? sayantn I believe test-various runs some arm and android tests? @bors try job=test-various
Contributor
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#154186), which was unapproved. |
folkertdev
force-pushed
the
aarch64-arm-load-store
branch
from
d2c1b74 to
b44f9c1
Compare
Contributor
Author
|
apple formats the assembly slightly differently @bors try job=aarch64-apple |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2026
add neon load/store assembly test try-job: aarch64-apple
Contributor
Contributor
|
@bors r=sayantn |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 21, 2026
… r=sayantn add neon load/store assembly test I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics. r? sayantn I believe test-various runs some arm and android tests? @bors try job=test-various
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
…uwer Rollup of 7 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #154094 (add neon load/store assembly test) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move])
Member
|
Failed in rollup in @bors r- |
rust-bors
bot
added
the
S-waiting-on-author
rust-bors
bot
removed
the
S-waiting-on-bors
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#154192), which was unapproved. |
folkertdev
force-pushed
the
aarch64-arm-load-store
branch
from
b44f9c1 to
35f9cb6
Compare
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Right, so apparently we don't currently run CI with an arm target that supports @bors try jobs=armhf-gnu |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
add neon load/store assembly test try-job: armhf-gnu
Contributor
Contributor
|
@folkertdev would you prefer to just do a full try build to ensure that it doesn't fail anymore or should I re-approve it? |
Contributor
Author
|
Lost track of this, I think it should just be good now |
Contributor
|
ok let's try it out @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 24, 2026
… r=sayantn add neon load/store assembly test I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics. r? sayantn I believe test-various runs some arm and android tests? @bors try job=test-various
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 24, 2026
… r=sayantn add neon load/store assembly test I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics. r? sayantn I believe test-various runs some arm and android tests? @bors try job=test-various
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
…uwer Rollup of 7 pull requests Successful merges: - #149218 (Make PinCoerceUnsized require Deref) - #154094 (add neon load/store assembly test) - #154142 (Delegation: eliminate usage of AST from generics creation) - #154276 (allow `incomplete_features` in more tests) - #154284 (doc: linker-plugin-based LTO: update list of good combinations) - #154286 (Cherry-pick 1.94.1 release notes) - #154303 (Remove more `BuiltinLintDiag` variants - part 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
I'm adding this test because it was requested for the beta backport of #153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.
r? sayantn
I believe test-various runs some arm and android tests?
@bors try job=test-various