Skip to content

Rollup of 6 pull requests#154316

Merged
rust-bors[bot] merged 14 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-qSafo91
Mar 24, 2026
Merged

Rollup of 6 pull requests#154316
rust-bors[bot] merged 14 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-qSafo91

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Mar 24, 2026

Successful merges:

r? @ghost

Create a similar rollup

folkertdev and others added 14 commits March 22, 2026 18:39
@folkertdev
add neon load/store assembly test
35f9cb6
@cyrgani
allow incomplete_features in more tests
7df43d3
@zamazan4ik
doc: update list of Rustc and Clang LTO compatibility
3f67327
@Mark-Simulacrum
Cherry-pick 1.94.1 release notes
3df450f 
This also fixes the Cargo rendering bug noted in the pre-release thread.
@GuillaumeGomez
Remove more BuiltinLintDiag in rustc_attr_parsing
eba0efd
@GuillaumeGomez
Remove more BuiltinLintDiag in rustc_middle
45027f1
@GuillaumeGomez
Remove more BuiltinLintDiag in rustc_resolve
5d7f894
@aerooneqq
Eliminate usage of AST from generics creation
1d325ce
@JonathanBrouwer
Rollup merge of rust-lang#154094 - folkertdev:aarch64-arm-load-store,…
898b62f 
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
@JonathanBrouwer
Rollup merge of rust-lang#154142 - aerooneqq:dont-create-ast-generics…
1cfbc50 
…-2, r=petrochenkov

Delegation: eliminate usage of AST from generics creation

This PR eliminates all interaction with AST during creation of generics, then it supports proper const param types propagation. Fixes rust-lang#153433. Fixes rust-lang#153499. Part of rust-lang#118212.

r? @petrochenkov
@JonathanBrouwer
Rollup merge of rust-lang#154276 - cyrgani:incomplete-mcp-2, r=fmease
a1c32ca 
allow `incomplete_features` in more tests

This PR allows the `incomplete_features` lint for the `traits` and `const-generics` directories. `specialization` will come in a followup PR.

Followup to rust-lang#154174.
Part of rust-lang#154168.
@JonathanBrouwer
Rollup merge of rust-lang#154284 - zamazan4ik:patch-1, r=JohnTitor
eb7fa12 
doc: linker-plugin-based LTO: update list of good combinations

This PR is similar to rust-lang#146827 . I just ran the Python script as was [recommended](rust-lang#146827 (review)) in this comment. Also updated the LOWER_BOUND in the script to skip a bit redundant work in the Python script.

@nnethercote pinging you as a reviewer here since the last time you did it too ;)
@JonathanBrouwer
Rollup merge of rust-lang#154286 - Mark-Simulacrum:relnotes, r=jieyouxu
a77ea21 
Cherry-pick 1.94.1 release notes

This also fixes the Cargo rendering bug noted in the pre-release thread (https://internals.rust-lang.org/t/rust-1-94-1-pre-release-testing/24107/2).
@JonathanBrouwer
Rollup merge of rust-lang#154303 - GuillaumeGomez:migrate-diag2, r=Jo…
a532706 
…nathanBrouwer

Remove more `BuiltinLintDiag` variants - part 2

Part of rust-lang#153099.

r? @JonathanBrouwer
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 24, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Mar 24, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Mar 24, 2026

@bors r+ rollup=never p=5

1 similar comment
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Mar 24, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit a532706 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit a532706 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot mentioned this pull request Mar 24, 2026
Merged
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 27s
Pushing 63154b7 to main...

@rust-bors rust-bors bot merged commit 63154b7 into rust-lang:main Mar 24, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0312931 (parent) -> 63154b7 (this PR)

Test differences

Show 46 test diffs

Stage 1

  • [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#AARCH64: [missing] -> ignore (only executed when the target is aarch64-unknown-linux-gnu) (J2)
  • [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#ARMV7: [missing] -> ignore (only executed when the target is armv7-unknown-linux-gnueabihf) (J2)
  • [ui] tests/ui/delegation/generics/const-type-ice-153433.rs: [missing] -> pass (J2)
  • [ui] tests/ui/delegation/generics/const-type-ice-153499.rs: [missing] -> pass (J2)

Stage 2

  • [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#AARCH64: [missing] -> pass (J0)
  • [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#ARMV7: [missing] -> ignore (ignored when the operating system is android) (J1)
  • [ui] tests/ui/delegation/generics/const-type-ice-153433.rs: [missing] -> pass (J3)
  • [ui] tests/ui/delegation/generics/const-type-ice-153499.rs: [missing] -> pass (J3)
  • [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#ARMV7: [missing] -> ignore (only executed when the target is armv7-unknown-linux-gnueabihf) (J4)
  • [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#AARCH64: [missing] -> ignore (only executed when the target is aarch64-unknown-linux-gnu) (J5)

Additionally, 36 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 63154b7b47fd77cc1012693a50c78d022fc0db25 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-22-2: 1h 40m -> 1h 22m (-17.6%)
  2. pr-check-1: 33m 9s -> 27m 48s (-16.1%)
  3. x86_64-gnu-llvm-21-1: 1h 14m -> 1h 3m (-15.0%)
  4. dist-aarch64-msvc: 1h 31m -> 1h 43m (+13.9%)
  5. i686-gnu-2: 1h 43m -> 1h 30m (-12.9%)
  6. optional-x86_64-gnu-parallel-frontend: 2h 41m -> 2h 22m (-11.7%)
  7. x86_64-rust-for-linux: 52m 10s -> 46m 21s (-11.2%)
  8. x86_64-gnu-tools: 1h 3m -> 56m 13s (-11.1%)
  9. x86_64-gnu-gcc: 1h 10m -> 1h 3m (-10.5%)
  10. x86_64-gnu-debug: 2h 11m -> 1h 57m (-10.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 24, 2026
Open
Draft
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 24, 2026

Finished benchmarking commit (63154b7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 5.7%, secondary -6.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 5.7% [5.7%, 5.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.7% [-6.7%, -6.7%] 1
All ❌✅ (primary) 5.7% [5.7%, 5.7%] 1

Cycles

Results (secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.1%] 54
Regressions ❌
(secondary)		 0.1% [0.0%, 0.1%] 22
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.0%, 0.1%] 54

Bootstrap: 484.31s -> 485.223s (0.19%)
Artifact size: 394.79 MiB -> 394.92 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer @rust-timer @rustbot @folkertdev @cyrgani @zamazan4ik @Mark-Simulacrum @GuillaumeGomez @aerooneqq