Skip to content

🔒 Fix DoS via unbounded IPFS file parsing#104

Merged
scobru merged 1 commit into
mainfrom
jules-15597975954597844808-5f7f1274
Jun 26, 2026
Merged

🔒 Fix DoS via unbounded IPFS file parsing#104
scobru merged 1 commit into
mainfrom
jules-15597975954597844808-5f7f1274

Conversation

@scobru

@scobru scobru commented Jun 22, 2026

Copy link
Copy Markdown
Owner

🎯 What: Added a 5MB size limit to memory buffering in IPFS API endpoints.
⚠️ Risk: An attacker or a malicious IPFS peer could serve an excessively large payload. This would cause the Node.js server to read unbounded data into memory, potentially blocking the event loop or causing Out-Of-Memory (OOM) crashes (Denial of Service).
🛡️ Solution: Implemented a `MAX_JSON_SIZE` constant limit. If the accumulated chunks exceed this limit during an incoming request, the server sets a flag, immediately destroys the connection, and returns a `413 Payload Too Large` HTTP response.


PR created automatically by Jules for task 15597975954597844808 started by @scobru

Co-authored-by: scobru <1079164+scobru@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@scobru scobru merged commit cabc829 into main Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant