Skip to content

🔒 Fix DoS via unbounded IPFS file parsing #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scobru merged 1 commit into from
Jun 26, 2026
Merged

🔒 Fix DoS via unbounded IPFS file parsing #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 51 additions & 2 deletions relay/src/routes/ipfs/cat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { loggers } from "../../utils/logger";
import type { CustomRequest, IpfsRequestOptions } from "./types";
import { IPFS_API_TOKEN, getContentTypeFromExtension, detectContentType } from "./utils";

const MAX_JSON_SIZE = 5 * 1024 * 1024; // 5MB maximum size for parsing JSON into memory

const router: Router = Router();

/**
Expand Down Expand Up @@ -210,8 +212,25 @@ router.post("/api/:endpoint(*)", async (req: CustomRequest, res: Response) => {

const ipfsReq = http.request(requestOptions, (ipfsRes) => {
let data = "";
ipfsRes.on("data", (chunk) => (data += chunk));
let totalLength = 0;
let isTooLarge = false;

ipfsRes.on("data", (chunk) => {
if (isTooLarge) return;
totalLength += chunk.length;
if (totalLength > MAX_JSON_SIZE) {
isTooLarge = true;
ipfsReq.destroy();
if (!res.headersSent) {
res.status(413).json({ success: false, endpoint, error: "Response payload too large" });
}
return;
}
data += chunk;
});

ipfsRes.on("end", () => {
if (isTooLarge) return;
loggers.server.debug({ endpoint, data }, `📡 IPFS API raw response`);

try {
Expand Down Expand Up @@ -397,15 +416,28 @@ router.get("/ipfs/:cid", async (req, res) => {
const ipfsReq = http.request(requestOptions, (ipfsRes) => {
let contentType = "application/octet-stream";
const chunks: Buffer[] = [];
let totalLength = 0;
let isTooLarge = false;

ipfsRes.on("data", (chunk: Buffer) => {
if (isTooLarge) return;
totalLength += chunk.length;
if (totalLength > MAX_JSON_SIZE) {
isTooLarge = true;
ipfsReq.destroy();
if (!res.headersSent) {
res.status(413).json({ success: false, error: "Response payload too large" });
}
return;
}
chunks.push(chunk);
if (chunks.length === 1 && chunk.length > 0) {
contentType = detectContentType(chunk);
}
});

ipfsRes.on("end", () => {
if (isTooLarge) return;
const buffer = Buffer.concat(chunks);
res.setHeader("Content-Type", contentType);
res.setHeader("Content-Length", buffer.length.toString());
Expand Down Expand Up @@ -465,8 +497,25 @@ router.get("/cat/:cid/json", async (req: Request, res: Response) => {

const ipfsReq = http.request(requestOptions, (ipfsRes) => {
let data = "";
ipfsRes.on("data", (chunk) => (data += chunk));
let totalLength = 0;
let isTooLarge = false;

ipfsRes.on("data", (chunk) => {
if (isTooLarge) return;
totalLength += chunk.length;
if (totalLength > MAX_JSON_SIZE) {
isTooLarge = true;
ipfsReq.destroy();
if (!res.headersSent) {
res.status(413).json({ success: false, error: "Response payload too large for JSON parsing" });
}
return;
}
data += chunk;
});

ipfsRes.on("end", () => {
if (isTooLarge) return;
try {
const jsonData = JSON.parse(data);
res.json({ success: true, cid, data: jsonData });
Expand Down
Loading