Skip to content

fix #194 Static widget is a string only #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robnagler merged 3 commits into from
Mar 5, 2026
Merged

fix #194 Static widget is a string only #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc3b749
fix #194 Static widget is a string only
moellep Feb 18, 2026
66ed0b5
unwritabled text/float/integer fields displayed with VStatic
moellep Mar 5, 2026
1a0381b
removed static widget def, use writable status instead
moellep Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .readthedocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 2
build:
os: ubuntu-22.04
tools:
python: "3.9"
python: "3.13"
jobs:
pre_build:
- curl https://radia.run | bash -s readthedocs
Expand Down
2 changes: 0 additions & 2 deletions slicops/package_data/sliclet/fractals.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ fields:
prototype: String
ui:
label: Fractal Status
widget: static
writable: false
plot:
prototype: Dict
Expand All @@ -46,7 +45,6 @@ fields:
plot_file:
prototype: String
ui:
widget: static
writable: false
#TODO(robnagler) need a "base.yaml" or something
revert:
Expand Down
2 changes: 0 additions & 2 deletions slicops/package_data/sliclet/screen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,11 @@ fields:
ui:
label: PV
writable: false
widget: static
target_status:
prototype: String
ui:
label: Target Status
writable: false
widget: static
single_button:
prototype: Button
ui:
Expand Down
1 change: 0 additions & 1 deletion slicops/package_data/sliclet/yaml_db.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ fields:
ui:
label: 'Output #1'
writable: False
widget: static
output2:
prototype: output1
ui:
Expand Down
24 changes: 13 additions & 11 deletions ui/src/components/layout/VCell.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,19 @@
:ctx="ctx"
/>
</div>
<div v-else-if="['text', 'float', 'integer'].includes(ctx[field].ui.widget)">
<VText
:field="field"
:ctx="ctx"
/>
</div>
<div v-else-if="ctx[field].ui.widget == 'static'">
<VStatic
:field="field"
:ctx="ctx"
/>
<div v-else-if="['string', 'float', 'integer'].includes(ctx[field].ui.widget)">
<div v-if="ctx[field].ui.writable === false">
<VStatic
:field="field"
:ctx="ctx"
/>
</div>
<div v-else>
<VText
:field="field"
:ctx="ctx"
/>
</div>
</div>
<div v-else-if="ctx[field].ui.widget == 'button'">
<VButton
Expand Down
9 changes: 3 additions & 6 deletions ui/src/components/widget/VStatic.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@
:ctx="ctx"
/>
<div>
<input
v-model="ctx[field].value"
class="form-control form-control-sm form-control-plaintext"
:id="field"
readonly
/>
<div class="form-control form-control-sm form-control-plaintext">
{{ ctx[field].value }}
</div>
</div>
</template>

Expand Down