Using MaxGasPrice from txRequest #323
Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR updates the transaction attempt builder to prioritize MaxGasPrice from transaction requests over the key-specific configuration, and updates a dependency version.
Changes:
- Modified
NewTxAttemptWithTypeto useMaxGasPricefrom the transaction request when available - Updated
chainlink-framework/chainsdependency to a newer version
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/txmgr/attempts.go | Added logic to override keySpecificMaxGasPriceWei with MaxGasPrice from transaction request when present |
| go.mod | Updated chainlink-framework/chains dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/txmgr/attempts.go
Outdated
| func (c *evmTxAttemptBuilder) NewTxAttemptWithType(ctx context.Context, etx Tx, lggr logger.Logger, txType int, opts ...fees.Opt) (attempt TxAttempt, fee gas.EvmFee, feeLimit uint64, retryable bool, err error) { | ||
| keySpecificMaxGasPriceWei := c.feeConfig.PriceMaxKey(etx.FromAddress) | ||
| if etx.MaxGasPrice != nil { | ||
| keySpecificMaxGasPriceWei = assets.NewWei(etx.MaxGasPrice) // give prefence to max gas price from tx request |
There was a problem hiding this comment.
Corrected spelling of 'prefence' to 'preference'.
| keySpecificMaxGasPriceWei = assets.NewWei(etx.MaxGasPrice) // give prefence to max gas price from tx request | |
| keySpecificMaxGasPriceWei = assets.NewWei(etx.MaxGasPrice) // give preference to max gas price from tx request |
✅ API Diff Results - No breaking changes |
2 participants
https://smartcontract-it.atlassian.net/browse/PLEX-1522
Depends on smartcontractkit/chainlink-framework#80