Skip to content

chore: update CODEOWNERS and fixes to CI errors#164

Merged
ecPablo merged 6 commits intodevelopfrom
update-codeowners
Jul 9, 2025
Merged

chore: update CODEOWNERS and fixes to CI errors#164
ecPablo merged 6 commits intodevelopfrom
update-codeowners

Conversation

@ecPablo
Copy link
Copy Markdown
Contributor

@ecPablo ecPablo commented Jul 8, 2025

No description provided.

@ecPablo ecPablo requested review from a team as code owners July 8, 2025 13:58
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 8, 2025

👋 ecPablo, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

ChrisAmora
ChrisAmora previously approved these changes Jul 8, 2025
gustavogama-cll
gustavogama-cll previously approved these changes Jul 8, 2025
@ecPablo ecPablo enabled auto-merge July 8, 2025 15:24
@ecPablo ecPablo changed the title Update CODEOWNERS Update CODEOWNERS and fixes to CI errors Jul 9, 2025
@ecPablo ecPablo changed the title Update CODEOWNERS and fixes to CI errors chore: update CODEOWNERS and fixes to CI errors Jul 9, 2025
Comment thread tests/containers/geth.go
// },
// Consumers: []testcontainers.LogConsumer{&StdoutLogConsumer{Prefix: "|| "}},
// },
LogConsumerCfg: &testcontainers.LogConsumerConfig{
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to keep logs here as default as they are helpful in case there are problems with the container during tests

@ecPablo ecPablo added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@gustavogama-cll gustavogama-cll added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@ecPablo ecPablo added this pull request to the merge queue Jul 9, 2025
Merged via the queue into develop with commit ce79de8 Jul 9, 2025
6 checks passed
@ecPablo ecPablo deleted the update-codeowners branch July 9, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants