Skip to content

chore: update CODEOWNERS and fixes to CI errors #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecPablo merged 6 commits into from
Jul 9, 2025
Merged

chore: update CODEOWNERS and fixes to CI errors #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d62eaa1
Update CODEOWNERS
ecPablo Jul 8, 2025
dda680a
fix: add config yaml
ecPablo Jul 9, 2025
03b1c6c
fix: paths config toml in unit tests
ecPablo Jul 9, 2025
03046e9
fix: debug geth container startup
ecPablo Jul 9, 2025
dabf147
fix: remove network id flag
ecPablo Jul 9, 2025
de04715
fix: keep logs for test debugging
ecPablo Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @smartcontractkit/deployment-automation @smartcontractkit/devex-tooling
* @smartcontractkit/devex-tooling
2 changes: 0 additions & 2 deletions .github/workflows/pull-request-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ jobs:
ci-test:
name: Tests
runs-on: ubuntu-latest
env:
CTF_CONFIGS: /home/runner/work/timelock-worker/timelock-worker/tests/integration/solana/artifacts
permissions:
id-token: write
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ jobs:
- name: Build and test
uses: smartcontractkit/.github/actions/ci-test-go@ci-test-go/0.3.5
with:
go-test-cmd: go test -short -coverprofile=coverage.out -covermode=atomic -race ./...
go-test-cmd: CTF_CONFIGS=./config.toml go test -short -coverprofile=coverage.out -covermode=atomic -race ./...
use-go-cache: true
14 changes: 6 additions & 8 deletions tests/containers/geth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,14 @@ func NewGethContainer(ctx context.Context) (*GethContainer, error) {
"--http", "--http.addr", "0.0.0.0", "--http.vhosts", "*",
"--ws", "--ws.addr", "0.0.0.0", "--ws.origins", "*",
"--cache.blocklogs", "1024",
"--networkid", fmt.Sprintf("%d", chainID),
"--datadir", dataDir,
},
// uncomment to print container logs to stdout
// LogConsumerCfg: &testcontainers.LogConsumerConfig{
// Opts: []testcontainers.LogProductionOption{
// testcontainers.WithLogProductionTimeout(10 * time.Second),
// },
// Consumers: []testcontainers.LogConsumer{&StdoutLogConsumer{Prefix: "|| "}},
// },
LogConsumerCfg: &testcontainers.LogConsumerConfig{
Copy link
Copy Markdown
Contributor Author

@ecPablo ecPablo Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to keep logs here as default as they are helpful in case there are problems with the container during tests

Opts: []testcontainers.LogProductionOption{
testcontainers.WithLogProductionTimeout(10 * time.Second),
},
Consumers: []testcontainers.LogConsumer{&StdoutLogConsumer{Prefix: "|| "}},
},
}
gethContainer, err := testcontainers.GenericContainer(ctx, testcontainers.GenericContainerRequest{
ContainerRequest: request,
Expand Down
Loading