[Repo Assist] fix: honour phpcbf.enable=false — store flag and guard format()#128
Draft
github-actions[bot] wants to merge 1 commit intomasterfrom
Draft
Conversation
as a guard in loadSettings() but had a critical side-effect problem: when enable=false the method returned early WITHOUT storing the value, leaving this.executablePath and other cached settings from a previous (enabled) call intact. As a result, disabling the extension via phpcbf.enable=false had no effect: format() would call loadSettings(), which returned early, then proceed to spawn phpcbf using the stale cached executablePath. Fix: - Always read and store this.enable before the early return in loadSettings(), so format() has a reliable flag to check. - Add an explicit early return in format() when this.enable is false, returning an empty TextEdit array immediately without spawning phpcbf. Closes #56 (fixes phpcbf.enable setting being a no-op). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated draft PR from Repo Assist, an AI assistant.
Summary
Fixes a bug where
phpcbf.enable = falsehad no effect: the extension continued to spawnphpcbfeven after being explicitly disabled.Root Cause
loadSettings()used this guard:No integration test infrastructure exists in the repo (protected
package.json/vscodetest harness). The fix is a straightforward guard addition and the logic is clearly correct from code inspection.Closes
Closes #56 (
phpcbf.enablesetting does not disable formatting).