Skip to content

[Repo Assist] fix: honour phpcbf.enable=false — store flag and guard format() #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Repo Assist] fix: honour phpcbf.enable=false — store flag and guard format() #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ class PHPCBF {
(window.activeTextEditor ? window.activeTextEditor.document.uri : null);

let config = workspace.getConfiguration("phpcbf", configUri);
if (!config.get("enable") === true) {
// Always read the enable flag first so format() can check it even when
// disabled. The original `!config.get("enable") === true` check returned
// early without storing the value, leaving stale settings in place and
// allowing phpcbf to run despite being disabled.
this.enable = config.get("enable", true);
if (!this.enable) {
return;
}
this.onsave = config.get("onsave", false);
Expand Down Expand Up @@ -132,6 +137,11 @@ class PHPCBF {
// per-folder settings are respected on every format call.
this.loadSettings(document.uri);

// Respect phpcbf.enable = false: return an empty edit list immediately.
if (!this.enable) {
return Promise.resolve([]);
}

if (this.debug) {
console.time("phpcbf");
}
Expand Down