Skip to content

MPT-19124 remove fixture scope#264

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19124
Mar 30, 2026
Merged

MPT-19124 remove fixture scope#264
jentyk merged 1 commit intomainfrom
feat/MPT-19124

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Mar 30, 2026

Closes MPT-19124

  • Changed pytest fixture scope from session to module for seven fixtures in tests/e2e/conftest.py:

    • mpt_vendor
    • async_mpt_vendor
    • mpt_ops
    • async_mpt_ops
    • mpt_client
    • async_mpt_client
    • rp_logger
  • Fixtures now have a module-level lifetime, meaning they are created once per test module instead of once per entire test session

@jentyk jentyk requested a review from a team as a code owner March 30, 2026 17:27
@jentyk jentyk requested review from d3rky and ruben-sebrango March 30, 2026 17:27
@sonarqubecloud
Copy link
Copy Markdown

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b87da0ae-b946-413f-958f-f5cabe925dcf

📥 Commits

Reviewing files that changed from the base of the PR and between 72e9a02 and 14aee1b.

📒 Files selected for processing (1)
  • tests/e2e/conftest.py

📝 Walkthrough

Walkthrough

Seven pytest fixtures in tests/e2e/conftest.py (mpt_vendor, async_mpt_vendor, mpt_ops, async_mpt_ops, mpt_client, async_mpt_client, and rp_logger) have their scope changed from "session" to "module". No fixture logic was modified; only the decorator scope parameter was updated.

Changes

Cohort / File(s) Summary
Pytest fixture scope updates
tests/e2e/conftest.py
Changed 7 fixtures from session-scoped to module-scoped: mpt_vendor, async_mpt_vendor, mpt_ops, async_mpt_ops, mpt_client, async_mpt_client, and rp_logger. Fixtures are now instantiated once per test module instead of once per test session.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title 'MPT-19124 remove fixture scope' contains exactly one Jira issue key in the correct format.
Test Coverage Required ✅ Passed PR modifies only test files in tests/e2e/conftest.py, changing pytest fixture scopes. No non-test code files were modified.
Single Commit Required ✅ Passed The PR contains a single commit that modified pytest fixture scopes in tests/e2e/conftest.py from session to module scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jentyk jentyk merged commit 7bd1fff into main Mar 30, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19124 branch March 30, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants