fix: fix vllm patching for realonly venvs - #8
Merged
soluwalana merged 1 commit intoAug 5, 2026
Conversation
4 tasks
anubhutivyas
force-pushed
the
fix-readonly-venv-vllm-patching/anubhutiv
branch
from
August 4, 2026 19:21
f6109c2 to
a7bf687
Compare
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
anubhutivyas
force-pushed
the
fix-readonly-venv-vllm-patching/anubhutiv
branch
from
August 5, 2026 19:44
a7bf687 to
73833ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
_locked_file_patchrunswhich creates a new entry in the venv's
site-packages/vllm/v1/executor/. That needs write permission on the directory and the venvs are made root-owned in our Dockerfile but the workers run as uid 1000, so it fails.Context on the fix:
chown -Ron the venvs is not the fix, because of what I learned today:I found out that
chown -Rhavoids that but only fixes the lock, symlink ownership is ignored for access checks. So, in the next few lines after the above code block we callIt still hits the read-only cache file. And where the
-hinchowndoes let the write through, it writes into the copy shared by both vllm venvs, each of which needs its own sys.executable in it. So, the fix is to stop needing directory write at all and move the lock out of site-packages, what is done in this PR and give each vllm venv a private copy of just the patched files which is done in this PR - NVIDIA-NeMo/nemo-platform#1056