Skip to content

ci: use reuse workflow for send email on fail#680

Merged
yungyuc merged 1 commit intosolvcon:masterfrom
ExplorerRay:ci-reuse-workflow
Feb 22, 2026
Merged

ci: use reuse workflow for send email on fail#680
yungyuc merged 1 commit intosolvcon:masterfrom
ExplorerRay:ci-reuse-workflow

Conversation

@ExplorerRay
Copy link
Collaborator

To remove duplicate steps in CI which is mentioned in #677, I use reuse workflows provided by Github to combine sending email on failure ones.

With this PR, we only need to maintain one workflow about email sending and other workflows only need to reuse it.

I have tested this on my local fork and ensure it works (ref). And the email body looks like below:
image

Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw>
Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I like the modularization.

@chestercheng, please take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the action should use a version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the reference, it states:

  • {owner}/{repo}/.github/workflows/{filename}@{ref} for reusable workflows in public and private repositories.
  • ./.github/workflows/{filename} for reusable workflows in the same repository.

Since we are using a workflow within the same repository, we do not need to specify @{ref} (such as a specific commit SHA, release tag, or branch name).

Regarding the reusable workflow YAML file itself, the official documentation doesn't mention specifying a version inside the file. I think it simply follows the repository’s version control.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. In our case, which uses the action within the same repository, it makes more sense to follow the latest checkin (repository version control).

We should not use a version. I like this conclusion.

@yungyuc yungyuc merged commit 92d897c into solvcon:master Feb 22, 2026
14 checks passed
@yungyuc
Copy link
Member

yungyuc commented Feb 22, 2026

Merged. Discussion can continue.

@yungyuc yungyuc added the array Multi-dimensional array implementation label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

array Multi-dimensional array implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants