-
Notifications
You must be signed in to change notification settings - Fork 55
ci: use reuse workflow for send email on fail #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: Send Email on Failure | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| job_results: | ||
| description: 'String of job results' | ||
| required: true | ||
| type: string | ||
| secrets: | ||
| EMAIL_USERNAME: | ||
| required: true | ||
| EMAIL_PASSWORD: | ||
| required: true | ||
|
|
||
| jobs: | ||
| send_email_on_failure: | ||
| name: send_emails_when_fails | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Get current date and set to env | ||
| run: | | ||
| echo "DATE=$(date +%m/%d)" >> $GITHUB_ENV | ||
|
|
||
| - name: Send mail to mailing list | ||
| uses: dawidd6/action-send-mail@v6 | ||
| with: | ||
| server_address: smtp.gmail.com | ||
| server_port: 465 | ||
| username: ${{ secrets.EMAIL_USERNAME }} | ||
| password: ${{ secrets.EMAIL_PASSWORD }} | ||
| # Subject: Uses the Repository name | ||
| subject: ${{ env.DATE }} CI Failure in ${{ github.repository }} ${{ github.workflow }} workflow | ||
| # Body: Lists the result of every job | ||
| body: | | ||
| The workflow ${{ github.workflow }} has failed. | ||
| Job Status Report: | ||
| ------------------ | ||
| ${{ inputs.job_results }} | ||
|
|
||
| Check the details at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
| to: solvcon@googlegroups.com | ||
| from: solvcon_notification |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the action should use a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the reference, it states:
Since we are using a workflow within the same repository, we do not need to specify
@{ref}(such as a specific commit SHA, release tag, or branch name).Regarding the reusable workflow YAML file itself, the official documentation doesn't mention specifying a version inside the file. I think it simply follows the repository’s version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. In our case, which uses the action within the same repository, it makes more sense to follow the latest checkin (repository version control).
We should not use a version. I like this conclusion.