Skip to content

Conversation

@g0rgamesh
Copy link
Contributor

  • diable zuul checks until they are fixed

@g0rgamesh g0rgamesh requested a review from a team as a code owner November 27, 2025 14:22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the check-review Zuul jobs to address failing checks. This is a reasonable temporary measure. My review includes a suggestion to add a reference to a tracking issue in the comment, which will improve maintainability by providing context for why the jobs are disabled and when they can be re-enabled. I've also suggested a cleaner way to comment out the YAML block. Lastly, there's a minor typo ('diable') in the pull request description.

Comment on lines +7 to +11
# Disable zuul checks until they are fixed.
# check-review:
# jobs:
# - tenks-ubuntu-noble
# - tenks-rocky-9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Disabling checks temporarily is a reasonable approach. To improve long-term maintainability, it's a best practice to include a reference to a tracking issue (e.g., a GitHub issue) in the comment. This provides context for why the checks are disabled and helps track when they should be re-enabled.

Additionally, the current commenting style for the YAML block could be difficult to uncomment correctly later. A cleaner approach is to prepend # to each line, preserving the original indentation, which makes uncommenting straightforward.

# Disable zuul checks until they are fixed (see #<issue-number>).
#    check-review:
#      jobs:
#        - tenks-ubuntu-noble
#        - tenks-rocky-9

@Alex-Welsh
Copy link
Member

I'm not sure we should disable them completely for now.
The check-review pipeline still runs, it just fails a lot.
I'd rather leave it running for now, and work on fixing it.

The check pipeline on the other hand, I don't see much benefit from. It just fails immediately, so we could remove that for now

@g0rgamesh
Copy link
Contributor Author

I'm not sure we should disable them completely for now. The check-review pipeline still runs, it just fails a lot. I'd rather leave it running for now, and work on fixing it.

The check pipeline on the other hand, I don't see much benefit from. It just fails immediately, so we could remove that for now

Ok, I'll close it then.

@g0rgamesh g0rgamesh closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants