Skip to content

disable zuul checks #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
g0rgamesh wants to merge 1 commit into from
Closed

disable zuul checks #2006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions zuul.d/project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
check:
jobs:
- openstack-tox-pep8

check-review:
jobs:
- tenks-ubuntu-noble
- tenks-rocky-9
# Disable zuul checks until they are fixed.
# check-review:
# jobs:
# - tenks-ubuntu-noble
# - tenks-rocky-9
Comment on lines +7 to +11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Disabling checks temporarily is a reasonable approach. To improve long-term maintainability, it's a best practice to include a reference to a tracking issue (e.g., a GitHub issue) in the comment. This provides context for why the checks are disabled and helps track when they should be re-enabled.

Additionally, the current commenting style for the YAML block could be difficult to uncomment correctly later. A cleaner approach is to prepend # to each line, preserving the original indentation, which makes uncommenting straightforward.

# Disable zuul checks until they are fixed (see #<issue-number>).
#    check-review:
#      jobs:
#        - tenks-ubuntu-noble
#        - tenks-rocky-9


gate:
jobs:
Expand Down
Loading