apollo_consensus_orchestrator: fix change_gas_price_overrides test to use override and not min data #11690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
guy-starkware
changed the title
guy-starkware
force-pushed
the
guyn/l1price/fix_overrides_test
branch
from
5aa081e to
374bb1d
Compare
This was referenced Jan 13, 2026
guy-starkware
force-pushed
the
guyn/l1price/fix_overrides_test
branch
from
374bb1d to
f57b44f
Compare
guy-starkware
force-pushed
the
guyn/l1price/overrides_in_fri
branch
from
b734523 to
8b861c9
Compare
ShahakShama
approved these changes
Jan 14, 2026
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware).
guy-starkware
changed the base branch from
guyn/l1price/overrides_in_fri
to
graphite-base/11690
guy-starkware
force-pushed
the
guyn/l1price/fix_overrides_test
branch
from
f57b44f to
44a8d49
Compare
guy-starkware
force-pushed
the
graphite-base/11690
branch
from
8b861c9 to
2f59b63
Compare
guy-starkware
changed the base branch from
graphite-base/11690
to
guyn/l1price/overrides_in_fri
guy-starkware
force-pushed
the
guyn/l1price/fix_overrides_test
branch
from
44a8d49 to
5abde9f
Compare
guy-starkware
force-pushed
the
guyn/l1price/overrides_in_fri
branch
from
2f59b63 to
2d6ab4b
Compare
guy-starkware
changed the base branch from
guyn/l1price/overrides_in_fri
to
main-v0.14.1-committer
guy-starkware
commented
Jan 15, 2026
Contributor
Author
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 10 files and all commit messages.
Reviewable status:
… use override and not min data
guy-starkware
force-pushed
the
guyn/l1price/fix_overrides_test
branch
from
5abde9f to
6fe4cac
Compare
guy-starkware
commented
Jan 15, 2026
Contributor
Author
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 10 files and all commit messages.
Reviewable status:
Merged
via the queue into
main-v0.14.1-committer
with commit Jan 15, 2026
02c414d
20 of 26 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.