apollo_consensus_orchestrator: add test for bad eth/strk conversions

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• apollo_consensus_orchestrator: add test for bad eth/strk conversions #11762 👈 (View in Graphite)
• apollo_consensus_orchestrator: fix bug in gas price conversion under rate override #11750
• apollo_consensus_orchestrator: add warning in case block info has a zero gas price #11694
• starknet_api: improve error msg on wei_to_fri and fri_to_wei #11691
• apollo_consensus_orchestrator: fix change_gas_price_overrides test to use override and not min data #11690
• apollo_consensus_orchestrator: use gas price overrides in fri instead of wei #11686
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

@ShahakShama reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @guy-starkware).

---

crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 999 at r1 (raw file):

    let expected_wei_to_fri_rate = override_eth_to_fri_rate.unwrap_or(ETH_TO_FRI_RATE);
    let expected_l1_gas_price = GasPrice(expected_l1_prices.base_fee_per_gas.0)

Rename to expected_l1_(data_)gas_price_fri

[ShahakShama]

@ShahakShama reviewed 2 files.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware).

[guy-starkware]

@guy-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @ShahakShama).

---

crates/apollo_consensus_orchestrator/src/sequencer_consensus_context_test.rs line 999 at r1 (raw file):

Previously, ShahakShama wrote…

Rename to expected_l1_(data_)gas_price_fri

Done.

[guy-starkware]

@guy-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware).