Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2869 +/- ##
==========================================
- Coverage 99.88% 99.80% -0.09%
==========================================
Files 359 360 +1
Lines 50860 50917 +57
==========================================
+ Hits 50804 50818 +14
- Misses 56 99 +43 ☔ View full report in Codecov by Sentry. |
| super().__init__() | ||
| self._known_reference_bool: Dict[str, bool] = {} | ||
| self._known_reference_int: Dict[str, bool] = {} | ||
| if json_file_abspath is not None: |
There was a problem hiding this comment.
This part would need to either be removed entirely (and the transformation purely on PSyIR information for determining compile-time constants) or replaced with functionality that enables a list of names/symbols to be provided to the apply method (to support run-time constants).
|
Thanks for this Hugo. Obviously this will need full testing etc. Also, the reading of the json file needs to be replaced with one or more parameters to |
e75f500 to
6e55a14
Compare
|
@arporter One year passes really quickly. Background information: This would be a good feature for, e.g., NEMO & Croco to eliminate if-branches once the parameters are known to be constant over runtime. |
This PR adds a new PsyIR transformation.
What this transformation should do exactly should be discussed between @schreiberx @arporter and other interested.
Currently there is no test, it is only reusing the code present in Martin's PR #2801.