Skip to content

chore(dev/onboarding): set up mise-based workflow for initial codebase setup#5761

Merged
jgoux merged 21 commits into
developfrom
kanad-2026-07-01/add-mise-config
Jul 3, 2026
Merged

chore(dev/onboarding): set up mise-based workflow for initial codebase setup#5761
jgoux merged 21 commits into
developfrom
kanad-2026-07-01/add-mise-config

Conversation

@kanadgupta

@kanadgupta kanadgupta commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Adds a mise.toml along with enhancements to our CONTRIBUTING.md so first-time contributors have a quick and easy way to install all the correct versions of all of the required software (Node, Bun, Go, golangci-lint, pnpm) to get tests running.

I tried to minimize the amount of additional configuration, utilizing existing files (e.g., .nvmrc, go.mod, package.json) as the respective versioning sources of truth where applicable.

I also chose not to commit a mise.lock lockfile for simplicity's sake but I'm happy to add it if folks want to lean into mise further in this repo.

What is the current behavior?

If someone clones the repo for the first time, they'll need to manually download all of the executables (Node, Bun, Go, golangci-lint) and look in a few different places to determine which versions to use.

What is the new behavior?

Now, users can install mise and run mise install and it'll install the correct versions of all the required software:

CleanShot.2026-07-02.at.08.04.14.mp4

@kanadgupta kanadgupta marked this pull request as ready for review July 2, 2026 15:07
@kanadgupta kanadgupta requested a review from a team as a code owner July 2, 2026 15:07
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@26d0c81d829859eaad28926d0c5c709e1be4f1ef

Preview package for commit 26d0c81.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3820f1b03c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread mise.toml Outdated
Comment thread mise.toml Outdated
Comment thread mise.toml Outdated

@avallete avallete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments and nitpicks, leaving approval to @Coly010 given my comment about NX/monorepo.

Thanks for this PR !

Also, the PR title I think should be chore: as it's only adding dev tools for contributors, nothing user facing in a release.

Comment thread .github/actions/setup/action.yml Outdated
Comment thread mise.toml Outdated
Comment thread mise.toml Outdated
Comment thread CONTRIBUTING.md Outdated
@kanadgupta kanadgupta changed the title feat: set up mise-based workflow for initial codebase setup chore(dev/onboarding): set up mise-based workflow for initial codebase setup Jul 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68862e363e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread CONTRIBUTING.md
Comment thread mise.toml Outdated
Comment thread CONTRIBUTING.md
Comment thread .github/actions/setup/action.yml Outdated
Comment thread .tool-versions Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4784613cd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/cli-go-ci.yml Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread .github/actions/setup/action.yml Outdated
@jgoux jgoux added this pull request to the merge queue Jul 3, 2026
Merged via the queue into develop with commit f6aff1c Jul 3, 2026
29 checks passed
@jgoux jgoux deleted the kanad-2026-07-01/add-mise-config branch July 3, 2026 10:50

@kanadgupta kanadgupta left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to use mise in CI! I have an idea for simplifying the caching setup in #5778 — will see if it actually does the trick.

Comment thread mise.toml
"go:github.com/golangci/golangci-lint/v2/cmd/golangci-lint" = "2.1.6"

[settings]
idiomatic_version_file_enable_tools = ["node", "bun", "pnpm"]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 did not realize that this option supported pnpm — nice catch!

Comment on lines +29 to +40
const packageJson = JSON.parse(readFileSync("package.json", "utf8"));
const payload = {
bun: readFileSync(".bun-version", "utf8").trim(),
mise: readFileSync("mise.toml", "utf8").trim(),
node: packageJson.devEngines?.runtime,
pnpm: packageJson.packageManager,
};
const digest = createHash("sha256")
.update(JSON.stringify(payload))
.digest("hex");
console.log(`hash=${digest}`);
JS

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an idea for simplifying this so we don't need to manually grab all of the source files to construct the cache key — see #5778. Still needs testing!

mittal-parth pushed a commit to mittal-parth/supabase-cli that referenced this pull request Jul 3, 2026
## What kind of change does this PR introduce?

Follow-up enhancement to supabase#5761. Adds
[a `mise.lock` lockfile](https://mise.jdx.dev/dev-tools/mise-lock.html)
and uses that as our cache key (as opposed to building our own).

## What is the current behavior?

`mise` cache in CI is built by manually grabbing all of the source files
and creating our own hash.

## What is the new behavior?

Uses the `mise.lock` file to create the file hash. Hopefully same
caching behavior as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants