chore(ci/mise): add lockfile, simplify caching behavior#5778
Merged
Conversation
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@30052027e6a65d823b9cd0da6f90ca8852a3f6fcPreview package for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a96f6f21f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
kanadgupta
commented
Jul 3, 2026
jgoux
approved these changes
Jul 3, 2026
mittal-parth
pushed a commit
to mittal-parth/supabase-cli
that referenced
this pull request
Jul 3, 2026
## What kind of change does this PR introduce? Upgrades `golangci-lint` to the latest version, per my findings in supabase#5778 (comment) ## What is the current behavior? The build succeeds, but the `golangci-lint` version isn't pointing to an actual commit in the repo: ``` $ golangci-lint --version golangci-lint has version v2.1.6 built with go1.25.11 from (unknown, modified: ?, mod sum: "h1:LXqShFfAGM5BDzEOWD2SL1IzJAgUOqES/HRBsfKjI+w=") on (unknown) ``` ## What is the new behavior? The `golangci-lint` version now points to an actual commit in the repo: ```sh $ golangci-lint --version golangci-lint has version 2.12.2 built with go1.26.2 from c0d3ddc9 on 2026-05-06T11:07:58Z ``` Hopefully no other changes in behavior!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Follow-up enhancement to #5761. Adds a
mise.locklockfile and uses that as our cache key (as opposed to building our own).What is the current behavior?
misecache in CI is built by manually grabbing all of the source files and creating our own hash.What is the new behavior?
Uses the
mise.lockfile to create the file hash. Hopefully same caching behavior as before.