fix: use explicit UTF-8 encoding in AuthParser URL decode/encode#12696
Open
ChihweiLHBird wants to merge 2 commits intoswagger-api:3.0.0from
Open
fix: use explicit UTF-8 encoding in AuthParser URL decode/encode#12696ChihweiLHBird wants to merge 2 commits intoswagger-api:3.0.0from
ChihweiLHBird wants to merge 2 commits intoswagger-api:3.0.0from
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
There was a problem hiding this comment.
Pull request overview
This PR updates AuthParser to use explicit UTF-8 encoding for URL decode/encode operations, eliminating reliance on platform defaults and removing an outdated FIXME.
Changes:
- Replace deprecated
URLDecoder.decode(String)usage withURLDecoder.decode(String, String)using UTF-8. - Update
URLEncoder.encode(..., "UTF-8")calls to useStandardCharsets.UTF_8.name(). - Remove the old FIXME comment about deprecated decoding.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java
Outdated
Show resolved
Hide resolved
modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java
Show resolved
Hide resolved
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
URLDecoder.decode(String)withURLDecoder.decode(String, String)usingStandardCharsets.UTF_8inAuthParser.parse()URLEncoder.encode()inAuthParser.reconstruct()to useStandardCharsets.UTF_8.name()instead of a hardcoded"UTF-8"string literal