Skip to content

fix: use explicit UTF-8 encoding in AuthParser URL decode/encode #12696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChihweiLHBird wants to merge 2 commits into
base: 3.0.0
Choose a base branch
from
+10 −4
Open

fix: use explicit UTF-8 encoding in AuthParser URL decode/encode #12696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6419e74
fix: replace deprecated URLDecoder method with charset specification
ChihweiLHBird Mar 24, 2026
48ebb8c
Change exception to UncheckedIOException
ChihweiLHBird Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.UncheckedIOException;
import java.io.UnsupportedEncodingException;
import java.net.URLDecoder;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.List;

Expand All @@ -22,8 +25,11 @@ public static List<AuthorizationValue> parse(String urlEncodedAuthStr) {
for (String part : parts) {
String[] kvPair = part.split(":");
if (kvPair.length == 2) {
// FIXME replace the deprecated method by decode(string, encoding). Which encoding is used ? Default UTF-8 ?
auths.add(new AuthorizationValue(URLDecoder.decode(kvPair[0]), URLDecoder.decode(kvPair[1]), "header"));
try {
auths.add(new AuthorizationValue(URLDecoder.decode(kvPair[0], StandardCharsets.UTF_8.name()), URLDecoder.decode(kvPair[1], StandardCharsets.UTF_8.name()), "header"));
} catch (UnsupportedEncodingException e) {
throw new UncheckedIOException("UTF-8 is not supported", e);
}
}
}
}
Expand All @@ -38,9 +44,9 @@ public static String reconstruct(List<AuthorizationValue> authorizationValueList
if (b.toString().length() > 0) {
b.append(",");
}
b.append(URLEncoder.encode(v.getKeyName(), "UTF-8"))
b.append(URLEncoder.encode(v.getKeyName(), StandardCharsets.UTF_8.name()))
.append(":")
.append(URLEncoder.encode(v.getValue(), "UTF-8"));
.append(URLEncoder.encode(v.getValue(), StandardCharsets.UTF_8.name()));
} catch (Exception e) {
// continue
LOGGER.error(e.getMessage(), e);
Expand Down