Adopt tap::tools namespace and TapHouse v4#18
Merged
Conversation
Normalize the drift-check ref off a raw SHA to v4 and add the canonical .pre-commit-config.yaml (required by the v4 drift set). No tidy.sh: this repo runs only the clang-format gate (kernel clang-tidy lives in TapTools-Max). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
Aligns TapTools with the tap::<lib> family convention (tap::dsp, tap::ambi, tap::mu, tap::samplerate, ...). Only the outer C++ namespace changes; the nested object namespaces (tr808, tb303, svf, vco, nr, spectra, vocoder, fft, ...) ride along as tap::tools::*. The taptools/ include directory, the TapTools::taptools CMake target, the TapToolsKernel project, and the taptools_* C ABI are external contracts and stay as-is (mirroring AmbiTap's ambitap/ + AmbiTap::ambitap under tap::ambi). The radix-2 fft.h is only renamed here; routing the spectral kernels (conv_engine/stft/nr/spectra) onto DspTap's real FFT is a separate, benchmarked change. All kernel tests pass; the C ABI still builds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
tap::tools is wider than taptools, which shifted clang-format's consecutive-declaration alignment columns in a few files. Reformat with the Tap-wide pinned clang-format (v18.1.3) so the clang-format gate passes. No functional change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the TapTools kernel in line with the rest of the Tap family.
Namespace:
taptools→tap::toolsAligns the library with the
tap::<lib>convention (tap::dsp,tap::ambi,tap::mu,tap::samplerate, …). Only the outer C++ namespace changes;the nested per-object namespaces ride along automatically:
tap::tools::{tr808, tb303, svf, vco, ladder, diode, autowah, nr, spectra, vocoder, fivecomb, pitchaccum, seq, fft, …}External contracts are unchanged, mirroring AmbiTap (
ambitap/+AmbiTap::ambitapundertap::ambi):include/taptools/include directory and relative includes — unchangedTapTools::taptoolsCMake target andTapToolsKernelproject — unchangedtaptools_*C ABI (tools/capi) — unchangedHard rename, no back-compat alias.
FFT — scope note
The radix-2
fft.his only renamed in this PR. Routing the spectralkernels (
conv_engine,stft,nr,spectra) onto DspTap's shared realFFT — for the split-radix + vDSP/CMSIS backend speedups — is deliberately a
separate, benchmarked change, not folded in here.
TapHouse v4
Normalizes the shared-style pin and distributes
scripts/tidy.sh.Verification
ctest).🤖 Generated with Claude Code
https://claude.ai/code/session_01MRTDgYKY38WH8Bqz17W9k1
Generated by Claude Code