Adopt tap::tools namespace and TapHouse v4

.github/workflows/style.yml

@@ -8,10 +8,9 @@ on: [push, pull_request]
 jobs:
   drift:
     # Fails if this repo's .clang-format/.clang-tidy/STYLE.md diverge from TapHouse.
-    # TapHouse v2 (pinned by commit SHA until the v2 tag is created).
-    uses: tap/taphouse/.github/workflows/drift-check.yml@ff71d8146754e5e35374cfe0d191e0983219da3b
+    uses: tap/taphouse/.github/workflows/drift-check.yml@v4
     with:
-      ref: ff71d8146754e5e35374cfe0d191e0983219da3b
+      ref: v4
 
   clang-format:
     runs-on: ubuntu-latest

.pre-commit-config.yaml

@@ -0,0 +1,23 @@
+# Canonical Tap House pre-commit config — the single source of truth for the
+# Tap family's local formatting hook. Distributed to every Tap repo by
+# scripts/sync.sh (alongside .clang-format / .clang-tidy / STYLE.md) and kept
+# honest by the drift-check workflow, so every repo runs the SAME hook at the
+# SAME pinned clang-format version.
+#
+# Why the pin matters: an ad-hoc hook using each machine's own clang-format
+# would format differently than CI and be worse than none. The `rev` below is
+# the Tap-wide clang-format version — bump it HERE, re-sync, and every repo
+# (and its CI, which runs `pre-commit run --all-files`) moves together.
+#
+# Adopt in a consumer repo:
+#   1. taphouse/scripts/sync.sh /path/to/your-repo   # copies this file in
+#   2. cd your-repo && pre-commit install            # once per clone
+# Thereafter `git commit` formats staged C/C++ before it can be pushed, so the
+# clang-format CI gate can never fail on a local commit again.
+repos:
+  - repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v18.1.3            # Tap-wide clang-format version (matches CI)
+    hooks:
+      - id: clang-format
+        types_or: [c, c++]
+        exclude: '^third_party/'   # vendored sources are formatted upstream, never by us

README.md

@@ -15,15 +15,15 @@ same either way.
 
 | Kernel | Max object | Contents |
 |---|---|---|
-| `include/taptools/autowah.h` | `tap.autowah~` | Snow White-style envelope filter (`taptools::autowah`) |
-| `include/taptools/diode_ladder.h` | `tap.diode~` | ZDF TB-303 diode ladder (`taptools::diode`) |
-| `include/taptools/tb303_voice.h` | `tap.303~` | TB-303 acid-bass voice (`taptools::tb303`) |
-| `include/taptools/ladder.h` | `tap.ladder~` | ZDF Moog-style ladder (`taptools::ladder`) |
-| `include/taptools/svf.h` | `tap.svf~` | Simper/Cytomic morphing SVF (`taptools::svf`) |
-| `include/taptools/vco.h` | `tap.vco~` | Virtual-analog oscillator (`taptools::vco`) |
-| `include/taptools/grm_comb.h` | `tap.5comb~` | GRM comb-bank recreation (`taptools::fivecomb`) |
-| `include/taptools/grm_pitchaccum.h` | `tap.pitchaccum~` | GRM PitchAccum recreation (`taptools::pitchaccum`) |
-| `include/taptools/conv_engine.h` | `tap.convolve~` | Partitioned (UPOLS) true-stereo convolution (`taptools::conv_engine`) |
+| `include/taptools/autowah.h` | `tap.autowah~` | Snow White-style envelope filter (`tap::tools::autowah`) |
+| `include/taptools/diode_ladder.h` | `tap.diode~` | ZDF TB-303 diode ladder (`tap::tools::diode`) |
+| `include/taptools/tb303_voice.h` | `tap.303~` | TB-303 acid-bass voice (`tap::tools::tb303`) |
+| `include/taptools/ladder.h` | `tap.ladder~` | ZDF Moog-style ladder (`tap::tools::ladder`) |
+| `include/taptools/svf.h` | `tap.svf~` | Simper/Cytomic morphing SVF (`tap::tools::svf`) |
+| `include/taptools/vco.h` | `tap.vco~` | Virtual-analog oscillator (`tap::tools::vco`) |
+| `include/taptools/grm_comb.h` | `tap.5comb~` | GRM comb-bank recreation (`tap::tools::fivecomb`) |
+| `include/taptools/grm_pitchaccum.h` | `tap.pitchaccum~` | GRM PitchAccum recreation (`tap::tools::pitchaccum`) |
+| `include/taptools/conv_engine.h` | `tap.convolve~` | Partitioned (UPOLS) true-stereo convolution (`tap::tools::conv_engine`) |
 
 Plus, all Max-free:
 

bench/diode_bench.cpp

@@ -21,7 +21,7 @@
 
 #include <taptools/diode_ladder.h>
 
-namespace dio = taptools::diode;
+namespace dio = tap::tools::diode;
 
 namespace {
 

bench/svf_bench.cpp

@@ -26,7 +26,7 @@
 
 #include <taptools/svf.h>
 
-namespace ksv = taptools::svf;
+namespace ksv = tap::tools::svf;
 
 namespace {
 

book/src/machine/autowah.md

@@ -14,7 +14,7 @@ proved in [the SVF appendix](svf.md) — is A-stability under per-sample
 cutoff modulation. An envelope-swept filter moves its cutoff *every sample by
 construction*; the property the wah needs most is exactly the one `svf.h`
 already guarantees by theorem. So `wah_filter` owns a
-`taptools::svf::svf_filter` member (`m_svf`) and drives it through the
+`tap::tools::svf::svf_filter` member (`m_svf`) and drives it through the
 signal-rate path, `m_svf.tick(m_cutoff)` then `m_svf.process(0, x)`, once
 per sample. The house rule makes this legal: objects under
 `source/projects/` stay self-contained, but *inside the kernel repo* sharing

book/src/machine/comb.md

@@ -7,7 +7,7 @@ tune*, and that `phase` at 100 cancels the even harmonics — exactly. This
 appendix derives all three the way the file was designed, then walks the
 code-level decisions. The behavioral claims below are pinned by the kernel
 scenarios in `tap.5comb_tilde_test.cpp`, which drive
-`taptools::fivecomb::comb_bank` directly (no Max in the loop); the few
+`tap::tools::fivecomb::comb_bank` directly (no Max in the loop); the few
 numbers outside the test suite are marked as measured on the kernel for
 this chapter.
 

book/src/machine/pitchaccum.md

@@ -6,7 +6,7 @@ tenth pass is as steady as the first." The image is a topology claim and the
 promise is an identity about a pair of window functions, and both are
 provable. This appendix proves them with the file's own names, then walks
 the pitch follower's failure mode and the ledger. The kernel scenarios in
-`tap.pitchaccum_tilde_test.cpp` drive `taptools::pitchaccum::accum_bank`
+`tap.pitchaccum_tilde_test.cpp` drive `tap::tools::pitchaccum::accum_bank`
 directly and pin every measured claim; the sibling `tap.shift~` tests pin
 the envelope identity to nine decimal places.
 

include/taptools/autowah.h

@@ -55,7 +55,7 @@
 
 #include "svf.h"
 
-namespace taptools {
+namespace tap::tools {
     namespace autowah {
 
         constexpr double k_pi                = 3.14159265358979323846;
@@ -480,4 +480,4 @@ namespace taptools {
         };
 
     } // namespace autowah
-} // namespace taptools
+} // namespace tap::tools

include/taptools/bridged_t.h

@@ -39,7 +39,7 @@
 #include <algorithm>
 #include <cmath>
 
-namespace taptools {
+namespace tap::tools {
     namespace tr808 {
 
         constexpr double k_pi = 3.14159265358979323846;
@@ -200,4 +200,4 @@ namespace taptools {
         };
 
     } // namespace tr808
-} // namespace taptools
+} // namespace tap::tools

include/taptools/conv_engine.h

@@ -32,7 +32,7 @@
 
 #include "fft.h" // the shared radix-2 FFT (formerly a private copy of this exact routine)
 
-namespace taptools {
+namespace tap::tools {
 
     class conv_engine {
       public:
@@ -231,4 +231,4 @@ namespace taptools {
         int m_fdl{0}; // ring index of the newest input spectrum
     };
 
-} // namespace taptools
+} // namespace tap::tools

include/taptools/diode_ladder.h

@@ -75,7 +75,7 @@
 #include <cmath>
 #include <cstddef>
 
-namespace taptools {
+namespace tap::tools {
     namespace diode {
 
         constexpr int    k_presets           = 16;
@@ -558,4 +558,4 @@ namespace taptools {
         };
 
     } // namespace diode
-} // namespace taptools
+} // namespace tap::tools

include/taptools/fft.h

@@ -15,7 +15,7 @@
 #include <cmath>
 #include <vector>
 
-namespace taptools {
+namespace tap::tools {
     namespace fft {
 
         inline constexpr double k_pi = 3.14159265358979323846;
@@ -68,4 +68,4 @@ namespace taptools {
         }
 
     } // namespace fft
-} // namespace taptools
+} // namespace tap::tools

include/taptools/grm_comb.h

@@ -36,7 +36,7 @@
 #include <cstddef>
 #include <vector>
 
-namespace taptools {
+namespace tap::tools {
     namespace fivecomb {
 
         constexpr int    k_voices            = 5;
@@ -523,4 +523,4 @@ namespace taptools {
         };
 
     } // namespace fivecomb
-} // namespace taptools
+} // namespace tap::tools

include/taptools/grm_pitchaccum.h

@@ -32,7 +32,7 @@
 #include <cstdint>
 #include <vector>
 
-namespace taptools {
+namespace tap::tools {
     namespace pitchaccum {
 
         constexpr int    k_voices            = 2;
@@ -666,4 +666,4 @@ namespace taptools {
         };
 
     } // namespace pitchaccum
-} // namespace taptools
+} // namespace tap::tools

include/taptools/ladder.h

@@ -43,7 +43,7 @@
 #include <cmath>
 #include <cstddef>
 
-namespace taptools {
+namespace tap::tools {
     namespace ladder {
 
         constexpr int    k_presets           = 16;
@@ -498,4 +498,4 @@ namespace taptools {
         };
 
     } // namespace ladder
-} // namespace taptools
+} // namespace tap::tools

include/taptools/metal_bank.h

@@ -40,7 +40,7 @@
 #include "bridged_t.h" // k_pi
 #include "swing_vca.h" // white_noise (seed machinery)
 
-namespace taptools {
+namespace tap::tools {
     namespace tr808 {
 
         constexpr int    k_bank_oscs            = 6;
@@ -174,4 +174,4 @@ namespace taptools {
         };
 
     } // namespace tr808
-} // namespace taptools
+} // namespace tap::tools

include/taptools/nr.h

@@ -18,7 +18,7 @@
 
 #include "stft.h"
 
-namespace taptools {
+namespace tap::tools {
     namespace nr {
 
         class reducer {
@@ -66,4 +66,4 @@ namespace taptools {
         };
 
     } // namespace nr
-} // namespace taptools
+} // namespace tap::tools

include/taptools/spectra.h

@@ -18,7 +18,7 @@
 
 #include "stft.h"
 
-namespace taptools {
+namespace tap::tools {
     namespace spectra {
 
         class remapper {
@@ -81,4 +81,4 @@ namespace taptools {
         };
 
     } // namespace spectra
-} // namespace taptools
+} // namespace tap::tools

include/taptools/step_seq.h

@@ -58,7 +58,7 @@
 #include <algorithm>
 #include <cmath>
 
-namespace taptools {
+namespace tap::tools {
     namespace seq {
 
         constexpr int k_max_steps      = 64;
@@ -326,4 +326,4 @@ namespace taptools {
         };
 
     } // namespace seq
-} // namespace taptools
+} // namespace tap::tools

include/taptools/stft.h

@@ -20,7 +20,7 @@
 
 #include "fft.h"
 
-namespace taptools {
+namespace tap::tools {
 
     class stft {
       public:
@@ -121,4 +121,4 @@ namespace taptools {
         std::vector<double> m_im;     // scratch FFT imag
     };
 
-} // namespace taptools
+} // namespace tap::tools

include/taptools/svf.h

@@ -58,7 +58,7 @@
 #include <cstddef>
 #include <vector>
 
-namespace taptools {
+namespace tap::tools {
     namespace svf {
 
         constexpr double k_pi                = 3.14159265358979323846;
@@ -667,4 +667,4 @@ namespace taptools {
         };
 
     } // namespace svf
-} // namespace taptools
+} // namespace tap::tools

include/taptools/swing_vca.h

@@ -27,9 +27,9 @@
 #include <cmath>
 #include <cstdint>
 
-#include "vca.h" // taptools::vca::swing_shape — the shared swing-type saturator
+#include "vca.h" // tap::tools::vca::swing_shape — the shared swing-type saturator
 
-namespace taptools {
+namespace tap::tools {
     namespace tr808 {
 
         /// Deterministic white noise in [-1, 1] — xorshift64* keyed by seed.
@@ -114,11 +114,11 @@ namespace taptools {
         /// The swing-type VCA: envelope as gain. Linear by default (`drive` 0 → `x * env`, the
         /// calibrated model, bit-for-bit); `drive > 0` engages the swing VCA's symmetric harmonic
         /// saturation (the "many high harmonics" the Service Notes note) on the enveloped signal,
-        /// via the shared taptools::vca::swing_shape. The character rides the envelope — quiet tails
+        /// via the shared tap::tools::vca::swing_shape. The character rides the envelope — quiet tails
         /// stay clean, hot transients pick up grit and gentle compression.
         inline double swing_vca(double x, double env, double drive = 0.0) {
             return vca::swing_shape(x * env, drive);
         }
 
     } // namespace tr808
-} // namespace taptools
+} // namespace tap::tools