Refactored amidst.mojangapi.file#331
Merged
Merged
Conversation
…inecraftDirectoryService
…yerInformation to PlayerInformationService
... instead of the MojangApiParsingException. This enables the usage of the JsonReader to parse json that was not provided by Mojang.
... not sure if it was implicitly required before
…UnresolvedLauncherProfile
…ous MinecraftInterface usages
This was referenced Jun 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the classes in
amidst.mojangapi.fileinto:This also replaces the meaningless class
MojangApiby more meaningful classes.Finally, the version list download mechanism has been reworked, so when Amidst is started initially, the local version list is used and the download of the up-to-date remote version list is started. As soon as the remote version list is available, it will be used instead. This prevents Amidst from "hanging" on startup when it has to wait for a server response.
This should not interfere too much with #169, since most of the changes are in different classes. However, the package
amidst.mojangapi.file.json.filterdoes not really belong into theamidst.mojangapi.filepackage, since the seed search json file format is not provided by Mojang. Instead, we should probably create a separate packageamidst.seedsearchwhich contains all seed search related stuff. I did not do this in this PR to prevent conflicts with #169.