Fix active providers not reloading after settings changes#3
Open
AlexMattyou wants to merge 1 commit into
Open
Conversation
Author
|
And, if you do need to optimise the call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While configuring S3 backups, I noticed that changing the Path Prefix setting had no effect. Backups continued to be uploaded to the original location even after saving the new configuration.
After investigating, I found that settings were being saved correctly by Logseq, but active providers were not being refreshed with the updated configuration. Existing S3/WebDAV provider instances continued using stale settings until Logseq was restarted or the provider was disabled and re-enabled.
Changes:
Result:
Configuration changes such as Path Prefix, credentials, and other provider settings are now applied immediately without requiring a Logseq restart or provider toggle.
And, thanks man. This was the only and only plugin I found to sync the Logseq with my s3. With this simple fix I hope the flow can be seemless! 🫡