Skip to content

Fix active providers not reloading after settings changes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexMattyou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix active providers not reloading after settings changes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/services/backup-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,13 @@ export class BackupService {
}
}

// Initialize new providers
// Initialize new providers and update existing ones
for (const providerName of currentProviders) {
if (!previousProviders.includes(providerName)) {
try {
console.info(`Initializing new provider: ${providerName}`);
await this.initializeProvider(providerName);
} catch (error) {
console.error(`Failed to initialize ${providerName} provider:`, error);
}
try {
console.info(`Initializing/Updating provider: ${providerName}`);
await this.initializeProvider(providerName);
} catch (error) {
console.error(`Failed to initialize ${providerName} provider:`, error);
}
}
}
Expand Down
18 changes: 8 additions & 10 deletions src/services/sync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,15 @@ export class SyncService {
this.providers.delete(providerName);
}
}
}

// Add newly enabled providers
for (const providerName of currentProviders) {
if (!previousProviders.includes(providerName) && !this.providers.has(providerName)) {
const provider = ProviderRegistry.createProvider(providerName);
if (provider) {
const success = await provider.initialize(this.settings);
if (success) {
this.providers.set(providerName, provider);
}
}
// Add newly enabled providers and update existing ones
for (const providerName of currentProviders) {
const provider = ProviderRegistry.createProvider(providerName);
if (provider) {
const success = await provider.initialize(this.settings);
if (success) {
this.providers.set(providerName, provider);
}
}
}
Expand Down