Skip to content

encoding: streaming-first Go deserialization redesign #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trippwill merged 30 commits into from
Apr 13, 2026

fix: address round-3 PR review comments

9ec9157
Select commit
Loading
Failed to load commit list.
Merged

encoding: streaming-first Go deserialization redesign #5

fix: address round-3 PR review comments
9ec9157
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 13, 2026 in 1s

72.80% (+2.78%) compared to f81685b

View this Pull Request on Codecov

72.80% (+2.78%) compared to f81685b

Details

Codecov Report

❌ Patch coverage is 67.39130% with 360 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.80%. Comparing base (f81685b) to head (9ec9157).

Files with missing lines Patch % Lines
encoding/read_value.go 65.26% 68 Missing and 31 partials ⚠️
encoding/reader_scalar_buf.go 62.05% 45 Missing and 40 partials ⚠️
encoding/navigation.go 59.82% 32 Missing and 13 partials ⚠️
encoding/unmarshal_new.go 70.79% 21 Missing and 12 partials ⚠️
encoding/pack_iter.go 52.00% 16 Missing and 8 partials ⚠️
encoding/converter.go 64.40% 12 Missing and 9 partials ⚠️
encoding/unit_reader.go 79.20% 16 Missing and 5 partials ⚠️
encoding/reader.go 73.52% 9 Missing ⚠️
encoding/reader_value_helpers.go 62.50% 5 Missing and 4 partials ⚠️
encoding/event.go 83.72% 3 Missing and 4 partials ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           redesign/deserialization       #5      +/-   ##
============================================================
+ Coverage                     70.01%   72.80%   +2.78%     
============================================================
  Files                            40       45       +5     
  Lines                          7074     6835     -239     
  Branches                        463      463              
============================================================
+ Hits                           4953     4976      +23     
+ Misses                         1586     1372     -214     
+ Partials                        535      487      -48
Files with missing lines Coverage Δ
dotnet/src/Pakt/PaktException.cs 100.00% <ø> (ø)
encoding/bytesource.go 86.66% <ø> (+10.47%) ⬆️
encoding/decoder.go 92.30% <ø> (+20.78%) ⬆️
encoding/options.go 100.00% <100.00%> (ø)
encoding/tags.go 85.21% <100.00%> (ø)
encoding/unmarshal.go 68.64% <100.00%> (+11.34%) ⬆️
encoding/marshal.go 67.79% <60.00%> (-0.90%) ⬇️
encoding/reader_state.go 77.36% <80.00%> (-0.04%) ⬇️
encoding/errors.go 91.66% <82.35%> (+49.56%) ⬆️
encoding/event.go 86.48% <83.72%> (+3.15%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov