-
Notifications
You must be signed in to change notification settings - Fork 0
encoding: streaming-first Go deserialization redesign #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1579d81
design: add deserialization design exploration
trippwill 006a109
encoding: streaming-first deserialization redesign
trippwill b2df11c
encoding: add composite navigation helpers
trippwill 661f0c2
encoding: rename StructFields → ReflectStructFields for tag introspec…
trippwill 22e4e61
encoding: add financial benchmark dataset (1K/10K trades)
trippwill 4437186
encoding: add JSON NDJSON streaming comparison for financial benchmarks
trippwill 0f4b80b
encoding: align benchmark naming scheme
trippwill 0a5ee59
encoding: Event.Value []byte with borrow semantics
trippwill 0b2a3c0
encoding: zero-copy scalar readers write directly to valBuf
trippwill c86aadb
encoding: zero-copy readBinTo avoids intermediate string allocation
trippwill d0aff72
encoding: rename StatementReader → UnitReader, Statement → Property
trippwill e9df934
site, docs: update Go API examples to new UnitReader design
trippwill e49d707
encoding: unsafe.String for zero-copy scalar parsing in ReadValue
trippwill abd8617
encoding: remove dead string-returning scalar readers
trippwill 44dcb9c
spec: compact error codes — remove reserved code 2
trippwill 75f11ca
encoding: improve test coverage 71.3% → 77.6%
trippwill 2f83cac
encoding: tighten lint rules + add 5 fuzz tests
trippwill 11e8453
ci: add weekly fuzz testing workflow
trippwill 3a5cefb
site: fix hero example — unquoted timestamps, atom set, better comment
trippwill 1a2ebbc
fix: suppress gosec G115 false positives, fix staticcheck QF1012
trippwill 072b53d
ci: use mise for Go toolchain, pin golangci-lint v2.11.4
trippwill c7cf902
ci: fix workflow issues found in review
trippwill 1440e77
encoding: improve patch coverage for new code paths
trippwill a5fe3a3
encoding: boost patch coverage, lower patch target to 60%
trippwill a8d743d
fix: address all PR review comments
trippwill ffb1561
fix: StructFields/TupleElements infinite loop on unconsumed values
trippwill dfca701
fix: address all round-2 PR review comments
trippwill 4286549
encoding: remove RegisterNamedConverter
trippwill aa66f54
docs: update design doc to match final API
trippwill 9ec9157
fix: address round-3 PR review comments
trippwill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: Fuzz | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 4 * * 1' # Monday 4am UTC | ||
| workflow_dispatch: | ||
| inputs: | ||
| fuzztime: | ||
| description: 'Fuzz duration per target (Go duration string)' | ||
| default: '5m' | ||
| type: string | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| fuzz: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| target: | ||
| - FuzzDecode | ||
| - FuzzUnmarshalNew | ||
| - FuzzReadString | ||
| - FuzzParseIntLiteral | ||
| - FuzzParseType | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: jdx/mise-action@v2 | ||
| with: | ||
| install_args: go | ||
|
|
||
| - name: Restore fuzz corpus | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cache/go-test-fuzz | ||
| encoding/testdata/fuzz | ||
| key: fuzz-corpus-${{ matrix.target }}-week-${{ github.run_number }} | ||
| restore-keys: | | ||
| fuzz-corpus-${{ matrix.target }}-week- | ||
| fuzz-corpus-${{ matrix.target }}- | ||
|
|
||
| - name: Fuzz ${{ matrix.target }} | ||
| run: | | ||
| go test ./encoding/ \ | ||
| -fuzz=${{ matrix.target }} \ | ||
| -fuzztime=${{ inputs.fuzztime || '5m' }} \ | ||
| -race | ||
|
|
||
| - name: Upload crash artifacts | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: fuzz-crash-${{ matrix.target }} | ||
| path: encoding/testdata/fuzz/${{ matrix.target }}/ | ||
| retention-days: 30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| [tools] | ||
| go = "1.25" | ||
| golangci-lint = "2.11.4" | ||
| hugo = "latest" | ||
| node = "22" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ coverage: | |
| threshold: 2% | ||
| patch: | ||
| default: | ||
| target: 70% | ||
| target: 65% | ||
|
|
||
| ignore: | ||
| - "main.go" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.