[v0.x] Implement Readiness class for outgoing backpressure#544
Closed
timbertson wants to merge 1 commit intotypelevel:series/0.xfrom
Closed
[v0.x] Implement Readiness class for outgoing backpressure#544timbertson wants to merge 1 commit intotypelevel:series/0.xfrom
timbertson wants to merge 1 commit intotypelevel:series/0.xfrom
Conversation
For outgoing streams, this class delays outgoing messages until the underlying channel has capacity.
timbertson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is loosely based on #39, but I pulled out the Readiness class for reuse and more explicit wiring.
For outgoing streams, this class delays outgoing messages until the underlying channel has capacity (using
isReady/onReady). This is used for clients sending a stream and for server responding with a stream.Note: I'm stuck way back on v0.x, because my project depends on cats-effect 2 via monix. I don't know if you are accepting pulls to such an old branch, but this was easier for me to test. If you're happy with the basic approach, I'll have a look at porting to
main.